Skip to content

[UDFS] Fix NULL-free in UDFBuildHashEntry to prevent BSOD (0xC4/0x10)#216

Draft
Copilot wants to merge 11 commits into
udf-devfrom
copilot/udfs-modify-filename-code
Draft

[UDFS] Fix NULL-free in UDFBuildHashEntry to prevent BSOD (0xC4/0x10)#216
Copilot wants to merge 11 commits into
udf-devfrom
copilot/udfs-modify-filename-code

Conversation

Copy link
Copy Markdown

Copilot AI commented Apr 6, 2026 •
edited
Loading

  • Fetch origin/udf-dev
  • Reset branch to origin/udf-dev (drop messy merge/revert history)
  • Re-apply the single net fix: wrap UDFBuildHashEntry hash ops in if (UName.Buffer) in dirtree.cpp
  • Push rebased branch

Copilot AI linked an issue Apr 6, 2026 that may be closed by this pull request
[UDFS] Modify filename code to prevent BSODs from occurring on shutdown, etc. #215
Open
Copilot AI changed the title [WIP] Fix filename code to prevent BSODs on shutdown [UDFS] Guard against NULL UdfName->Buffer in UDFDOSName to prevent BSODs on shutdown Apr 6, 2026
Copilot AI requested a review from Zero3K20 April 6, 2026 17:21
Copilot stopped work on behalf of Zero3K20 due to an error April 6, 2026 17:37
The session was cancelled by the user.
@Zero3K20 Zero3K20 closed this Apr 6, 2026
@Zero3K20 Zero3K20 deleted the copilot/udfs-modify-filename-code branch April 6, 2026 17:39
@Zero3K20 Zero3K20 restored the copilot/udfs-modify-filename-code branch April 7, 2026 14:16
@Zero3K20 Zero3K20 reopened this Apr 7, 2026
@Zero3K20 Zero3K20 changed the base branch from write to udf-dev April 27, 2026 06:47
@Zero3K20
Copy link
Copy Markdown
Owner

Zero3K20 commented Apr 27, 2026

@copilot Please fix the conflicts.

@Zero3K20
Merge origin/udf-dev and re-apply NULL guard fix in UDFDOSName
9423589 
Co-authored-by: Zero3K20 <258969903+Zero3K20@users.noreply.github.com>
@Zero3K20
Copy link
Copy Markdown
Owner

Zero3K20 commented Apr 27, 2026

@copilot I wanted the change that moved the freeing to the success branch, not the guard.

Copy link
Copy Markdown
Author

Copilot AI commented Apr 27, 2026

@copilot I wanted the change that moved the freeing to the success branch, not the guard.

Done. Removed the UDFDOSName guard and instead wrapped the RtlUpcaseUnicodeString / crc32 / ExFreePoolWithTag calls in UDFBuildHashEntry inside if (UName.Buffer) so the free only happens on the success branch (commit 25c7f67b).

Copilot AI changed the title [UDFS] Guard against NULL UdfName->Buffer in UDFDOSName to prevent BSODs on shutdown [UDFS] Fix NULL-free in UDFBuildHashEntry to prevent BSOD (0xC4/0x10) Apr 27, 2026
This was referenced Apr 30, 2026
Closed
Closed
Copilot AI added a commit that referenced this pull request May 1, 2026
@Zero3K20
Apply all open UDFS PRs: #62, #108, #193, #216, #218, #269, #277, #283,
8556073 
#302, #304, #306, #308, #310, #316, #335, #339

Agent-Logs-Url: https://github.com/Zero3K20/reactos/sessions/c135164e-e9f3-4164-ba64-d04f8a2dd19a

Co-authored-by: Zero3K20 <258969903+Zero3K20@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Zero3K20 Zero3K20 Awaiting requested review from Zero3K20

Assignees

Copilot code review Copilot

@Zero3K20 Zero3K20

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[UDFS] Modify filename code to prevent BSODs from occurring on shutdown, etc.

3 participants

@Zero3K20 @assorted