Skip to content

Admin: Implement event delegation for postbox UI lifecycle #12332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
himanshupathak95 wants to merge 1 commit into
base: trunk
Choose a base branch
from
+6 −9
Open

Admin: Implement event delegation for postbox UI lifecycle #12332

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 6 additions & 9 deletions src/js/_enqueues/admin/postbox.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -253,21 +253,18 @@
* @return {void}
*/
add_postbox_toggles : function (page, args) {
var $handles = $( '.postbox .hndle, .postbox .handlediv' ),
$orderButtons = $( '.postbox .handle-order-higher, .postbox .handle-order-lower' );

this.page = page;
this.init( page, args );

$handles.on( 'click.postboxes', this.handle_click );
$document.on( 'click.postboxes', '.postbox .hndle, .postbox .handlediv', this.handle_click );

// Handle the order of the postboxes.
$orderButtons.on( 'click.postboxes', this.handleOrder );
$document.on( 'click.postboxes', '.postbox .handle-order-higher, .postbox .handle-order-lower', this.handleOrder );

/**
* @since 2.7.0
*/
$('.postbox .hndle a').on( 'click', function(e) {
$document.on( 'click', '.postbox .hndle a', function(e) {
e.stopPropagation();
});

Expand All @@ -283,7 +280,7 @@
*
* @return {void}
*/
$( '.postbox a.dismiss' ).on( 'click.postboxes', function( e ) {
$document.on( 'click.postboxes', '.postbox a.dismiss', function( e ) {
var hide_id = $(this).parents('.postbox').attr('id') + '-hide';
e.preventDefault();
$( '#' + hide_id ).prop('checked', false).triggerHandler('click');
Expand All @@ -302,7 +299,7 @@
*
* @return {void}
*/
$('.hide-postbox-tog').on('click.postboxes', function() {
$document.on('click.postboxes', '.hide-postbox-tog', function() {
var $el = $(this),
boxId = $el.val(),
$postbox = $( '#' + boxId );
Expand Down Expand Up @@ -336,7 +333,7 @@
*
* @return {void}
*/
$('.columns-prefs input[type="radio"]').on('click.postboxes', function(){
$document.on('click.postboxes', '.columns-prefs input[type="radio"]', function(){
var n = parseInt($(this).val(), 10);

if ( n ) {
Expand Down
Loading