Skip to content

feat(access): can() fallback to SecurityPrincipal getRoles() #397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
usernane merged 1 commit into from
Jun 14, 2026
+36 −0
Merged

feat(access): can() fallback to SecurityPrincipal getRoles() #397

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions WebFiori/Framework/AccessManager.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,6 +153,10 @@ public function can($user, string $permission, ?object $resource = null): bool {
$userId = is_object($user) && method_exists($user, 'getId') ? $user->getId() : $user;
$roles = $this->getUserRoles($userId);

if (empty($roles) && is_object($user) && method_exists($user, 'getRoles')) {
$roles = $user->getRoles();
}

$hasPermission = false;

foreach ($roles as $roleName) {
Expand Down
32 changes: 32 additions & 0 deletions tests/WebFiori/Framework/Tests/AccessTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -648,4 +648,36 @@ public function testPermissionDbId() {
$perm->setDescription('Updated');
$this->assertEquals('Updated', $perm->getDescription());
}

/** @test */
public function testCanFallsBackToUserGetRoles() {
$manager = new AccessManager();
$manager->role('customer', ['VIEW_ORDERS']);

$user = new class {
public function getId() { return 55; }
public function getRoles(): array { return ['customer']; }
};

// No assignRoleToUser() — should fallback to $user->getRoles()
$this->assertTrue($manager->can($user, 'VIEW_ORDERS'));
$this->assertFalse($manager->can($user, 'DELETE_ORDERS'));
}

/** @test */
public function testCanPrefersInternalMapOverGetRoles() {
$manager = new AccessManager();
$manager->role('admin', ['MANAGE']);
$manager->role('viewer', ['VIEW']);

$user = new class {
public function getId() { return 56; }
public function getRoles(): array { return ['viewer']; }
};

// Internal map assigned — getRoles() should NOT be used
$manager->assignRoleToUser(56, 'admin');
$this->assertTrue($manager->can($user, 'MANAGE'));
$this->assertFalse($manager->can($user, 'VIEW'));
}
}
Loading