feat(access): can() fallback to SecurityPrincipal getRoles()#397
Merged
Conversation
When the internal userRoles map is empty for a user, can() now checks if the user object has a getRoles() method and uses those roles. Internal map still takes precedence when populated. Closes #381
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #397 +/- ##
============================================
+ Coverage 83.67% 83.75% +0.08%
- Complexity 3067 3086 +19
============================================
Files 103 104 +1
Lines 9018 9063 +45
============================================
+ Hits 7546 7591 +45
Misses 1472 1472
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When the internal role map is empty for a user,
can()falls back to$user->getRoles().Changes
AccessManager::can()Related issues
Closes #381