Improved factory manufacture#4153
Conversation
0c34ad5 to
c2e40cd
Compare
4c9de79 to
20f3cbc
Compare
|
This looks way more correct to me, I assume infinite repeat with 1 ordered would result in same behaviour, right? (and with +1 being rendered) What about client-side setting to optionally cancel or retain queue? I would personally probably not use it but bet there are some people who would be into that kind of stuff. |
Yeah, it'll finish that remaining droid and then it'll start making a new template (with count 4 on my screenshot).
Later. May be even in the next PR. |
|
tested |
|
Found edge case: When you have infinite order (or any complex order) and you have unit currently ordered and producing but you want to force-drop production progress, previously I just cancelled the queue with right click and it would switch to next in queue, currently no matter if I cancel the order it still finishes producing the unit and the only way to cancel it is to drop all orders with double right click on factory. This is very annoying and has to be addressed in some way. Example: I want to stop producing incendiary mortar immediately and forgot to dequeue it and end up completely wiping factory queues instead of specifically cancelling currently producing unit. |
|
This is a welcome improvement. I often make a factory produce something infinitely (like mortar) and when an upgrade is available (like pepperpot) I update the design template and add it back to production, but come back later to find out the factory has continued producing infinite mortars. |
@maxsupermanhd @past-due I can offer this solution to the issue. Although it will require double-clicking to cancel the current non-existent template and then the entire queue. |
|
I quit the game, I don't think my suggestions nor my work is of any value to this community. Feel free to disregard my nit. |
That's a shame. Your feedback was very helpful. |
|
@vaut Reports a desync testing the latest commit on this branch. It appears to be related (I haven't had a chance to dig into this fully yet.) |
How can I properly refund energy to a player without desyncs? |
|
I should clarify: I applied the patch and went into battle against players without the patch. (Because I thought the patches wouldn't affect synchronization.) |

When a droid template is modified and queued, we save the pointer to the new template in the old one, so that we can switch to it later.
2024-12-14.05-01-45.mp4