Skip to content

Create a shorthand for the formatted wzstring#4022

Closed
Monsterovich wants to merge 10 commits intoWarzone2100:masterfrom
Monsterovich:refactor-wzstring-format
Closed

Create a shorthand for the formatted wzstring#4022
Monsterovich wants to merge 10 commits intoWarzone2100:masterfrom
Monsterovich:refactor-wzstring-format

Conversation

@Monsterovich
Copy link
Copy Markdown
Contributor

@Monsterovich Monsterovich commented Jul 21, 2024

The equivalent of std::format from C++20.

@KJeff01 KJeff01 added the PR: Needs Review Check if this PR is still relevant or needs minor tweaks to be ready to merge label Oct 2, 2024
@KJeff01 KJeff01 added this to the 4.6.0 milestone Oct 2, 2024
Comment thread lib/framework/wzstring.h Outdated
Copy link
Copy Markdown
Member

@ManManson ManManson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small nitpick, otherwise LGTM.

@ManManson ManManson added Enhancement and removed PR: Needs Review Check if this PR is still relevant or needs minor tweaks to be ready to merge labels Nov 17, 2024
@Monsterovich
Copy link
Copy Markdown
Contributor Author

@KJeff01 @past-due merge?

@KJeff01
Copy link
Copy Markdown
Member

KJeff01 commented Dec 15, 2024

It says there are merge conflicts yet won't say which file for some reason. So needs a rebase. Pastdue said he may need to add tweaks for potential compiler warnings last time I poked him about this.

I am also trying to reduce the chances of merging large PRs that touch many files until pastdue finishes his big project (probably art-rev switcher) to avoid more merge-conflict troubles for him.

I keep github notifications turned off. You can DM me Discord for faster contact however.

@Monsterovich
Copy link
Copy Markdown
Contributor Author

Monsterovich commented Dec 15, 2024

It says there are merge conflicts yet won't say which file for some reason.

@KJeff01 Hm. I've successfully merged this branch with master, there were no conflicts.

@ManManson ManManson modified the milestones: 4.6.0, 4.6.0-beta1 May 26, 2025
@past-due past-due modified the milestone: 4.6.0-beta1 Jun 25, 2025
@past-due past-due self-requested a review January 25, 2026 15:06
@past-due past-due added the PR: Needs Review Check if this PR is still relevant or needs minor tweaks to be ready to merge label Jan 25, 2026
@past-due
Copy link
Copy Markdown
Member

Superseded by and incorporated into #4787, which also enables format attribute checking for these sorts of C++ variadic template functions.

@past-due past-due closed this Jan 25, 2026
@past-due past-due removed the PR: Needs Review Check if this PR is still relevant or needs minor tweaks to be ready to merge label Jan 25, 2026
@Monsterovich Monsterovich deleted the refactor-wzstring-format branch January 25, 2026 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants