Use .srt subtitles instead of the legacy format#2587
Open
mt3d wants to merge 8 commits intoWarzone2100:masterfrom
Open
Use .srt subtitles instead of the legacy format#2587mt3d wants to merge 8 commits intoWarzone2100:masterfrom
mt3d wants to merge 8 commits intoWarzone2100:masterfrom
Conversation
The goal behind changing the format of the subtitles is make it easier to adjust their timings and translate them. Several parts of the code were rewritten in C++, to increase the readability of the new .srt parser, and to avoid out-of-bound errors that can arise when manipulating characters and memory directly.
The translations of subtitles were extracted from the available .po files, and new .srt files were created using them.
Contributor
|
Is there something wrong with this PR? @mt3d |
Contributor
Author
@berserkingyadis I made a mistake and accidentally deleted the branch. Anyway, everything is okay now. Thanks for asking. |
Member
|
@mt3d Do you happen to still have the script you used to pull the translations from the .po files and convert them to the .srt? Would be incredibly helpful for rebasing this. |
Member
|
@mt3d A ping to see if you can answer the above. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In their current format, the subtitles are hard to edit or translate. They cannot be read by any subtitling software, and to adjust their timings you have to convert them manually to a common subtitling format back and forth. Moreover, if you want to break long sentences into several lines, each line will appear as a separate string in Crowdin, which makes translating them harder.
Example:
To fix this, the game will now use the widely-used .srt format, and for translation, GNU's gettext will not be used anymore. Instead, the each file will be added separately to Crowdin.
Summary of the changes:
Remaining steps: