Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 34 additions & 0 deletions packages/vchart/__tests__/unit/interaction/base-trigger.test.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,34 @@
import { BaseTrigger } from '../../../src/interaction/triggers/base';
import type { IBaseTriggerOptions, ITriggerEventHandler } from '../../../src/interaction/interface/trigger';

class TestTrigger extends BaseTrigger<IBaseTriggerOptions> {
type = 'test';
readonly handler = jest.fn();

protected getEvents(): Array<{ type: string | string[]; handler: ITriggerEventHandler }> {
return [{ type: ['pointerdown', 'none', 'pointermove'], handler: this.handler }];
}
}

describe('BaseTrigger', () => {
it('unbinds every event in an array-valued trigger when released', () => {
const event = {
on: jest.fn(),
off: jest.fn(),
emit: jest.fn()
};
const trigger = new TestTrigger({ event, interaction: {} as IBaseTriggerOptions['interaction'] });

trigger.init();
trigger.release();

expect(event.on.mock.calls).toEqual([
['pointerdown', trigger.handler],
['pointermove', trigger.handler]
]);
expect(event.off.mock.calls).toEqual([
['pointerdown', trigger.handler],
['pointermove', trigger.handler]
]);
});
});
2 changes: 1 addition & 1 deletion packages/vchart/src/interaction/triggers/base.ts
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ export abstract class BaseTrigger<T extends IBaseTriggerOptions> implements ITri
if (evt.type && evt.handler) {
if (isArray(evt.type)) {
evt.type.forEach(evtType => {
evtType && evtType !== 'none' && this.options.event.on(evtType, evt.handler);
evtType && evtType !== 'none' && this.options.event.off(evtType, evt.handler);
});
} else {
evt.type !== 'none' && this.options.event.off(evt.type, evt.handler);
Expand Down
Loading