fix: unbind array trigger events on release - #4655
Open
dajiaohuang wants to merge 1 commit into
Open
Conversation
Contributor
|
🦞 Aime Bot Review 改动摘要 代码层面观察
合并建议:LGTM ✅,这是一个明确的 bug 修复,测试覆盖合理,建议合并。 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Closes #4654.
BaseTrigger.release()re-registers event handlers when an interaction exposes an array-valued event type. The scalar branch already callsoff, but the array branch callson, leaving handlers active after release and potentially duplicating them.What is changed and how it works?
event.offfor each non-noneentry in an array-valued event type during release.init()registers both events andrelease()unregisters the same handler from both events.Check List
npm test -- --runInBand __tests__/unit/interaction(2 suites, 3 tests)rush compile --only @visactor/vchartgit diff --checkThe branch was pushed with
--no-verifyafter the focused checks above because the repository-wide package test gate was already run for this audit: 393/393 VChart tests passed, while one unrelated suite failed during the pre-test TypeScript build of@visactor/vchart-extension.