Add test: if subset empty, dont crash#1557
Merged
Merged
Conversation
This ensures #1285 has been fixed. It looks like it was already fixed; the bug report seems to indicate the subsetting was previously crashing, rather than returning an empty UXarray. The current behavior seems to return an empty UXarray as expected.
rajeeja
approved these changes
Jul 10, 2026
rajeeja
left a comment
rajeeja
left a comment
Contributor
There was a problem hiding this comment.
Tested locally — test_empty_subset passes and full test_subset.py is green (11/11). Good fix, confirms the empty-subset contract holds.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1285
Overview
If subset is empty, uxarray should return empty array, not crash. This seems to already be the case. But, it also seems to be the primary issue of #1285. This PR adds a test to ensure that is the case.
PR Checklist
General
Testing