Skip to content

Downgrade to matplotlib<3.11 to fix RTD plots #1554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Sevans711 merged 4 commits into from
Jul 10, 2026
Merged

Downgrade to matplotlib<3.11 to fix RTD plots #1554

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
48764ac
Downgrade to matplotlib<3.11 to fix RTD plots
Sevans711 Jul 8, 2026
e7297eb
regression test for #1542
Sevans711 Jul 8, 2026
4b0a752
fix: need mpl<3.11 pin in .yml files too
Sevans711 Jul 9, 2026
d9c41d7
Merge branch 'main' into broken-RTD-plots-workaround
rajeeja Jul 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ci/asv.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ dependencies:
- datashader
- geoviews
- holoviews
- matplotlib-base
- matplotlib-base<3.11 # 3.11.0 breaks some plots but <3.11 is fine; see issue #1542.
- matplotlib-inline
- healpix
- netcdf4
Expand Down
2 changes: 1 addition & 1 deletion ci/docs.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ dependencies:
- myst-nb
- sphinx-design
- nbsphinx
- matplotlib-base
- matplotlib-base<3.11 # 3.11.0 breaks some plots but <3.11 is fine; see issue #1542.
- matplotlib-inline
- shapely
- hvplot
Expand Down
2 changes: 1 addition & 1 deletion ci/environment.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ dependencies:
- holoviews
- hvplot
- hypothesis
- matplotlib-base
- matplotlib-base<3.11 # 3.11.0 breaks some plots but <3.11 is fine; see issue #1542.
- matplotlib-inline
- netcdf4
- numba
Expand Down
2 changes: 1 addition & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ dependencies = [
"datashader",
"geoviews",
"holoviews",
"matplotlib",
"matplotlib<3.11", # matplotlib 3.11.0 breaks some plots but <3.11 is fine; see issue #1542.
"matplotlib-inline",
"netcdf4",
"numba",
Expand Down
16 changes: 16 additions & 0 deletions test/test_plot.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -229,3 +229,19 @@ def test_to_raster_pixel_ratio(gridpath, r1, r2):
f = r2 / r1
d = np.array(raster2.shape) - f * np.array(raster1.shape)
assert (d >= 0).all() and (d <= f - 1).all()

def test_plot_with_features(gridpath, datasetpath):
"""ensure can render a multiplot layout with geoviews features.
Regression test for issue #1542.
"""
gridpath = gridpath("ugrid", "geoflow-small", "grid.nc")
uxds1 = ux.open_dataset(gridpath, datasetpath("ugrid", "geoflow-small", "v1.nc"))
uxds2 = ux.open_dataset(gridpath, datasetpath("ugrid", "geoflow-small", "v2.nc"))
uxds1 = uxds1.isel(time=0, meshLayers=0) # plot currently expects 1D along n_node
uxds2 = uxds2.isel(time=0, meshLayers=0)
plot1 = uxds1["v1"].plot(features=['coastline'])
plot2 = uxds2["v2"].plot(features=['coastline'])
plot = plot1 + plot2
# the crash associated with issue #1542 only occurs when actually trying to render:
renderer = hv.renderer("matplotlib")
renderer.get_plot(plot)
Loading