Downgrade to matplotlib<3.11 to fix RTD plots#1554
Merged
Conversation
readthedocs plots are breaking on matplotlib 3.11 but not matplotlib<3.11. This is a workaround for issue #1542 until things get fixed upstream.
I checked, this test currently crashes on matplotlib 3.11, but not on matplotlib 3.10.9.
also remove a confusing comment in test_plot.py
rajeeja
approved these changes
Jul 10, 2026
rajeeja
left a comment
Contributor
There was a problem hiding this comment.
Verified locally: reproduced the #1542 crash on matplotlib 3.11.0 (figure size must be positive finite not [8. nan]) and confirmed it passes on matplotlib 3.10. Good workaround, and the regression test will tell us when it's safe to lift the pin. Approving.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
readthedocs plots are breaking on matplotlib 3.11 but not matplotlib<3.11; see issue #1542. Workaround for now: restrict to matplotlib<3.11 in the pyproject.toml.
This restriction should be removed once things get fixed upstream, either by matplotlib or by geoviews.
PR Checklist
General
Testing