Skip to content

fix(ui5-select): remove focus outline from input when dropdown is opened #13643

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
plamenivanov91 merged 4 commits into from
Jun 5, 2026
+25 −22
Merged

fix(ui5-select): remove focus outline from input when dropdown is opened #13643

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
96d2731
fix(ui5-select): remove focus outline from input when dropdown is opened
plamenivanov91 Jun 4, 2026
be7e5cc
Merge branch 'main' into select-double-focus-fix
plamenivanov91 Jun 5, 2026
56687ab
- fixed review comments
plamenivanov91 Jun 5, 2026
f08fbab
Merge branch 'main' into select-double-focus-fix
plamenivanov91 Jun 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions packages/main/cypress/specs/Select.cy.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -592,6 +592,30 @@ describe("Select - Accessibility", () => {
expect(accessInfo.label).to.equal("Updated Reference"); // Updated aria label from ref
});
});

it("should have focus only on the selected item when dropdown is opened (not on input)", () => {
cy.mount(
<Select>
<Option value="Option1">Option 1</Option>
<Option value="Option2" selected>Option 2</Option>
<Option value="Option3">Option 3</Option>
</Select>
);

cy.get("[ui5-select]").realClick();
cy.get("[ui5-select]").should("have.attr", "opened");

// The input focus ring should not be rendered while opened.
cy.get("[ui5-select]")
.shadow()
.find(".ui5-input-focusable-element")
.then(($el) => {
const style = window.getComputedStyle($el[0], "::after");
expect(style.getPropertyValue("border-style")).to.equal("none");
});

cy.focused().should("have.attr", "role", "option");
});
});

describe("Select - Popover", () => {
Expand Down
23 changes: 1 addition & 22 deletions packages/main/src/themes/Select.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,28 +8,7 @@
}

:host([opened]) .ui5-input-focusable-element::after {
content: var(--ui5_input_focus_pseudo_element_content);
position: absolute;
pointer-events: none;
z-index: 2;
border: var(--sapContent_FocusWidth) var(--sapContent_FocusStyle) var(--_ui5_input_focus_outline_color);
border-radius: var(--_ui5_input_focus_border_radius);
top: var(--_ui5_input_focus_offset);
bottom: var(--_ui5_input_focus_offset);
left: var(--_ui5_input_focus_offset);
right: var(--_ui5_input_focus_offset);
}

:host([value-state="Negative"][opened]:not([readonly])) .ui5-input-focusable-element:after {
border-color: var(--_ui5_input_focused_value_state_error_focus_outline_color);
}

:host([value-state="Critical"][opened]:not([readonly])) .ui5-input-focusable-element:after {
border-color: var(--_ui5_input_focused_value_state_warning_focus_outline_color);
}

:host([value-state="Positive"][opened]:not([readonly])) .ui5-input-focusable-element:after {
border-color: var(--_ui5_input_focused_value_state_success_focus_outline_color);
content: none;
}

:host([icon]) .ui5-select-root {
Expand Down
Loading