fix(ui5-select): remove focus outline from input when dropdown is opened#13643
Merged
Conversation
When the Select dropdown is activated, the focus should only be on the selected list item, not on the input element. Previously, both the input and the selected item showed focus indicators, violating accessibility standards for single focus. Hide the focus pseudo-element on the input when the popover is opened, ensuring only the selected item in the dropdown shows a focus indicator. - Modified Select.css to remove focus outline when [opened] attribute is set - Added accessibility test to verify focus behavior - All 68 Select tests pass Fixes: #13616
plamenivanov91
temporarily deployed
to
netlify-preview
GitHub Actions
Inactive
|
🚀 Deployed on https://pr-13643--ui5-webcomponents-preview.netlify.app |
kgogov
requested changes
Jun 5, 2026
Contributor
kgogov
left a comment
kgogov
left a comment
There was a problem hiding this comment.
The CSS change is correct and verified — computed styles confirm border-style: none / border-width: 0px on the ::after when opened, and visual inspection shows a single focus indicator on the selected list item only. Two issues need to be addressed before this is ready to merge.
plamenivanov91
temporarily deployed
to
netlify-preview
GitHub Actions
Inactive
plamenivanov91
temporarily deployed
to
netlify-preview
GitHub Actions
Inactive
kgogov
approved these changes
Jun 5, 2026
Contributor
kgogov
left a comment
kgogov
left a comment
There was a problem hiding this comment.
All findings addressed. The CSS fix is correct (content: none cleanly suppresses the pseudo-element), dead code removed, and the test now properly verifies both the computed style and focus placement. LGTM 🟢
plamenivanov91
temporarily deployed
to
netlify-preview
GitHub Actions
Inactive
|
🧹 Preview deployment cleaned up: https://pr-13643--ui5-webcomponents.netlify.app |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the Select dropdown is activated, the focus should only be on the selected list item, not on the input element. Previously, both the input and the selected item showed focus indicators, violating accessibility standards for single focus.
Hide the focus pseudo-element on the input when the popover is opened, ensuring only the selected item in the dropdown shows a focus indicator.
Fixes: #13616