Skip to content

fix(ui5-bar, ui5-button): prevent button badge from being clipped inside ui5-bar #13618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hinzzx wants to merge 1 commit into
base: main
Choose a base branch
from
+13 −5
Open

fix(ui5-bar, ui5-button): prevent button badge from being clipped inside ui5-bar #13618

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions packages/main/src/themes/Bar.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,8 @@
box-shadow: inherit;
border-radius: inherit;
min-width: 0;
overflow: hidden;
overflow-x: clip;
overflow-y: visible;
}

.ui5-bar-root .ui5-bar-startcontent-container,
Expand All @@ -39,7 +40,8 @@
flex: 1 1 auto;
padding: 0 var(--_ui5_bar-mid-container-padding-start-end);
min-width: 0;
overflow: hidden;
overflow-x: clip;
overflow-y: visible;
}

.ui5-bar-root .ui5-bar-startcontent-container {
Expand All @@ -54,7 +56,8 @@

.ui5-bar-root.ui5-bar-root-shrinked .ui5-bar-content-container {
min-width: 0px;
overflow: hidden;
overflow-x: clip;
overflow-y: visible;
height: 100%;
}

Expand All @@ -80,12 +83,17 @@
border: none;
}

::slotted(*:not([hidden])) {
::slotted(*:not([hidden]):not([ui5-button])) {
margin: 0 0.25rem;
display: inline-block;
max-width: 100%;
white-space: nowrap;
overflow: hidden;
text-overflow: ellipsis;
box-sizing: border-box;
}

::slotted([ui5-button]) {
margin: 0 0.25rem;
--_ui5_button_overlay_badge_offset: -0.25rem;
Copy link
Copy Markdown
Contributor

@GDamyanov GDamyanov Jun 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is redundant

Copy link
Copy Markdown
Contributor Author

@hinzzx hinzzx Jun 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On Cozy when a button is in a Bar and has a badge, the badge overflows outside the bar boundaries. It looks correct on compact though, so I will apply it only in Compact.

}
2 changes: 1 addition & 1 deletion packages/main/src/themes/Button.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -318,7 +318,7 @@ bdi {
position: absolute;
top: 0;
inset-inline-end: 0;
margin: -0.5rem;
margin: var(--_ui5_button_overlay_badge_offset, -0.5rem);
z-index: 1;
font-family: var(--sapButton_FontFamily);
font-size: var(--sapFontSmallSize);
Expand Down
Loading