fix(ui5-bar, ui5-button): prevent button badge from being clipped inside ui5-bar#13618
Open
hinzzx wants to merge 1 commit into
Open
fix(ui5-bar, ui5-button): prevent button badge from being clipped inside ui5-bar#13618hinzzx wants to merge 1 commit into
ui5-bar#13618hinzzx wants to merge 1 commit into
Conversation
Collaborator
|
🚀 Deployed on https://pr-13618--ui5-webcomponents-preview.netlify.app |
GDamyanov
requested changes
Jun 5, 2026
|
|
||
| ::slotted([ui5-button]) { | ||
| margin: 0 0.25rem; | ||
| --_ui5_button_overlay_badge_offset: -0.25rem; |
Contributor
Author
There was a problem hiding this comment.
On Cozy when a button is in a Bar and has a badge, the badge overflows outside the bar boundaries. It looks correct on compact though, so I will apply it only in Compact.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Button badges were cut off when the button sat inside a
ui5-bar. The bar's overflow rules clipped the badge that intentionally sticks out above the button.What We Did
What This Fixes
Before
After
Fixes: #13541