Skip to content

fix(workspace): complete split preview and bulk document actions - #228

Merged
ThisIs-Developer merged 4 commits into
mainfrom
agent/fix-mermaid-split-view-rendering
Jul 27, 2026
Merged

fix(workspace): complete split preview and bulk document actions#228
ThisIs-Developer merged 4 commits into
mainfrom
agent/fix-mermaid-split-view-rendering

Conversation

@ThisIs-Developer

@ThisIs-Developer ThisIs-Developer commented Jul 27, 2026

Copy link
Copy Markdown
Owner

What changed

  • Run the shared post-processing pipeline in the right-hand document split preview.
  • Render Mermaid, WaveDrom, Vega-Lite, PlantUML, D2, Graphviz, Markmap, LaTeX/MathJax, ABC notation, GeoJSON, TopoJSON, and 3D STL models in either preview pane.
  • Keep asynchronous renderer work independently current so one pane cannot overwrite or cancel the other pane's pending output.
  • Share Leaflet and Three.js loading with the primary preview, update split map/model themes, and dispose map/WebGL resources when split content changes or closes.
  • Reuse renderer loading, retry, error-state, and viewer-toolbar behavior while ignoring stale split results after a document changes or closes.
  • Add Open all and Move to… to the context menu when multiple documents are selected in the Explorer.
  • Keep mixed file/folder bulk selections limited to the existing safe delete action.

Why

The secondary document preview parsed and sanitized Markdown but did not invoke the asynchronous post-processing used by the main preview. Advanced content therefore stayed as raw LaTeX, raw map/model source, or on placeholders such as Rendering Mermaid…, Rendering WaveDrom…, and ABC's loading state.

The Explorer's multi-selection menu was also hard-coded to a single delete action, preventing common bulk workflows.

Impact

Advanced content—including interactive maps and 3D STL canvases—now renders normally on both sides of document split preview mode without leaving hidden renderer resources behind. Users can also open or relocate a multi-document selection in one action, including moves that use the existing Secret Workspace unlock and persistence flow.

Validation

  • node --check script.js
  • git diff --check
  • Rich-content and Explorer browser coverage: 25 passed, including split GeoJSON/TopoJSON/STL rendering, LaTeX/ABC split rendering, and functional bulk open/move scenarios
  • Split-view open/close interaction: 1 passed
  • Math review/typesetting regression: 1 passed
  • One unrelated pre-existing header-control expectation remains stale in the local split/tab harness

Fixes #227

@vercel

vercel Bot commented Jul 27, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
markdown-viwer Ready Ready Preview, Comment Jul 27, 2026 10:03am

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Jul 27, 2026

Copy link
Copy Markdown

Deploying markdownviewer with  Cloudflare Pages  Cloudflare Pages

Latest commit: 4d9fce3
Status: ✅  Deploy successful!
Preview URL: https://460f4a48.markdownviewer.pages.dev
Branch Preview URL: https://agent-fix-mermaid-split-view.markdownviewer.pages.dev

View logs

@ThisIs-Developer ThisIs-Developer changed the title fix(preview): render Mermaid in document split view fix(preview): render diagrams in document split view Jul 27, 2026
@ThisIs-Developer ThisIs-Developer changed the title fix(preview): render diagrams in document split view fix(workspace): complete split preview and bulk document actions Jul 27, 2026
@ThisIs-Developer
ThisIs-Developer marked this pull request as ready for review July 27, 2026 10:08
@ThisIs-Developer
ThisIs-Developer merged commit a49321f into main Jul 27, 2026
5 checks passed
@ThisIs-Developer
ThisIs-Developer deleted the agent/fix-mermaid-split-view-rendering branch July 27, 2026 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Mermaid diagram stuck at Rendering Mermaid in split view

1 participant