Skip to content

bugfix(scorch): Update scorch texture mip quality when changing texture quality setting #3119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
xezon merged 1 commit into from
Aug 13, 2026
+12 −0
Merged

bugfix(scorch): Update scorch texture mip quality when changing texture quality setting #3119

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions Core/GameEngineDevice/Include/W3DDevice/GameClient/W3DScorch.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ class W3DScorchInterface
virtual void freeBuffers() = 0;
virtual void clearAllScorches() = 0;
virtual void invalidateBuffers() = 0;
virtual void invalidateTexture() = 0;
virtual void addScorch(Vector3 location, Real radius, Scorches type) = 0;
virtual void drawScorches(WorldHeightMap& map) = 0;
};
Expand All @@ -50,6 +51,7 @@ class W3DScorch : public W3DScorchInterface
virtual void freeBuffers() override; ///< frees up scorch buffers.
virtual void clearAllScorches() override;
virtual void invalidateBuffers() override;
virtual void invalidateTexture() override;
virtual void addScorch(Vector3 location, Real radius, Scorches type) override;
virtual void drawScorches(WorldHeightMap& map) override; ///< Draws the scorch mark polygons in m_vertexScorch.

Expand Down Expand Up @@ -89,6 +91,7 @@ class W3DScorchDummy : public W3DScorchInterface
virtual void freeBuffers() override {}
virtual void clearAllScorches() override {}
virtual void invalidateBuffers() override {}
virtual void invalidateTexture() override {}
virtual void addScorch(Vector3, Real, Scorches) override {}
virtual void drawScorches(WorldHeightMap&) override {}
};
1 change: 1 addition & 0 deletions Core/GameEngineDevice/Source/W3DDevice/GameClient/BaseHeightMap.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -316,6 +316,7 @@ void BaseHeightMapRenderObjClass::setTextureLOD(Int lod)
m_treeBuffer->setTextureLOD(lod);
if (m_map)
m_map->setTextureLOD(lod);
m_scorches->invalidateTexture();
Comment thread
stephanmeesters marked this conversation as resolved.
}

//=============================================================================
Expand Down
8 changes: 8 additions & 0 deletions Core/GameEngineDevice/Source/W3DDevice/GameClient/W3DScorch.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,14 @@ void W3DScorch::invalidateBuffers()
m_curNumScorchIndices = 0;
}

void W3DScorch::invalidateTexture()
{
if (m_scorchTexture)
{
m_scorchTexture->Invalidate();
}
}

void W3DScorch::addScorch(Vector3 location, Real radius, Scorches type)
{
if (m_numScorches >= MAX_SCORCH_MARKS)
Expand Down
Loading