Skip to content

bugfix(saveload): Restore dock approach position reached flags on load #3117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
bobtista wants to merge 2 commits into
base: main
Choose a base branch
from
+4 −0
Draft

bugfix(saveload): Restore dock approach position reached flags on load #3117

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ec574e7
bugfix(saveload): Restore dock approach position reached flags on load
bobtista Aug 12, 2026
9037f30
bugfix(saveload): Restore dock approach position reached flags on loa…
bobtista Aug 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions Generals/Code/GameEngine/Source/GameLogic/Object/Update/DockUpdate/DockUpdate.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -600,8 +600,10 @@ void DockUpdate::xfer( Xfer *xfer )
for( vectorIndex = 0; vectorIndex < vectorSize; ++vectorIndex )
{
// Vector of Bool gets packed as bitfield internally
// TheSuperHackers @bugfix bobtista 12/08/2026 Write the unpacked value back on load
Bool unpack = m_approachPositionReached[vectorIndex];
xfer->xferBool( &unpack );
m_approachPositionReached[vectorIndex] = unpack;
}

// active docker
Expand Down
2 changes: 2 additions & 0 deletions GeneralsMD/Code/GameEngine/Source/GameLogic/Object/Update/DockUpdate/DockUpdate.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -615,8 +615,10 @@ void DockUpdate::xfer( Xfer *xfer )
for( vectorIndex = 0; vectorIndex < vectorSize; ++vectorIndex )
{
// Vector of Bool gets packed as bitfield internally
// TheSuperHackers @bugfix bobtista 12/08/2026 Write the unpacked value back on load
Bool unpack = m_approachPositionReached[vectorIndex];
xfer->xferBool( &unpack );
m_approachPositionReached[vectorIndex] = unpack;
}

// active docker
Expand Down
Loading