Skip to content

bugfix(network): Build map transfer paths with the platform separator - #3108

Draft
bobtista wants to merge 2 commits into
TheSuperHackers:mainfrom
bobtista:bobtista/bugfix/map-transfer-paths
Draft

bugfix(network): Build map transfer paths with the platform separator#3108
bobtista wants to merge 2 commits into
TheSuperHackers:mainfrom
bobtista:bobtista/bugfix/map-transfer-paths

Conversation

@bobtista

Copy link
Copy Markdown

GetBasePathFromPath and GetFileFromPath search only for '\\', and the six Get*FromMap helpers each rejoin with a literal "\\". Where paths use '/' the base resolves empty and the whole path becomes the file name:

in:      /home/user/GeneralsData/Maps/MyMap/MyMap.map
before:  \/home/user/GeneralsData/Maps/MyMap/MyMap.tga
after:   /home/user/GeneralsData/Maps/MyMap/MyMap.tga

Now the two helpers use getLastPathSeparator, and all six Get*FromMap share one GetFileInMapDirectory that joins with the platform separator.

Todo:

  • Transfer a custom map between two clients, both files arrive with matching checksums
  • Confirm a Windows build still transfers maps
  • Replicate to Generals — N/A, it's in Core

@bobtista
bobtista marked this pull request as draft August 11, 2026 15:51
@bobtista bobtista self-assigned this Aug 11, 2026
@bobtista bobtista added the Platform Work towards platform support, such as Linux, MacOS label Aug 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Platform Work towards platform support, such as Linux, MacOS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Map transfer does not place the received files on non-Windows builds

1 participant