Skip to content

bugfix(map): Write and scan the map cache with the platform separator - #3107

Draft
bobtista wants to merge 3 commits into
TheSuperHackers:mainfrom
bobtista:bobtista/bugfix/map-cache-separator
Draft

bugfix(map): Write and scan the map cache with the platform separator#3107
bobtista wants to merge 3 commits into
TheSuperHackers:mainfrom
bobtista:bobtista/bugfix/map-cache-separator

Conversation

@bobtista

Copy link
Copy Markdown

writeCacheINI does filepath.concat('\\') before appending the file name, and loadMapsFromMapCacheINI and loadMapsFromDisk build their paths the same way. Off Windows that character lands inside the file name:

before:  <user maps dir>/Maps\MapCache.ini
after:   <user maps dir>/MapCache.ini

Now all three go through getPathInDirectory and getLastPathSeparator, so the cache is written where it is read from and the map path shape is checked against whichever separator the listing actually used.

Todo:

  • A client with no existing cache writes maps/MapCache.ini at the correct path
  • Replicate to Generals — N/A, it's in Core

@bobtista bobtista self-assigned this Aug 11, 2026
@bobtista bobtista added the Platform Work towards platform support, such as Linux, MacOS label Aug 11, 2026
@bobtista
bobtista marked this pull request as draft August 11, 2026 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Platform Work towards platform support, such as Linux, MacOS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Map cache is not written on non-Windows builds

1 participant