bugfix(file): Keep the resolved prefix when a write path has a missing directory - #3104
Draft
bobtista wants to merge 1 commit into
Draft
bugfix(file): Keep the resolved prefix when a write path has a missing directory#3104bobtista wants to merge 1 commit into
bobtista wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On an unmatched component during a write the fixup does
pathFixed = p, replacing everything matched so far, and the followingpathFixed /= pathFixedPartappends nothing becausepathFixedPartis empty:Now the component is appended to the resolved prefix instead of replacing it. The comment above the line already said to use the last known good path.
Todo: