Skip to content

perf(script): Reduce cost of ScriptEngine::findScript() by around 85% #3096

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Mauller wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −4
Open

perf(script): Reduce cost of ScriptEngine::findScript() by around 85% #3096

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions GeneralsMD/Code/GameEngine/Include/GameLogic/Scripts.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,7 @@ class ScriptGroup : public MemoryPoolObject, public Snapshot
void setWarnings(Bool warnings) { m_hasWarnings = warnings;}
void setNextGroup(ScriptGroup *pGr) {m_nextGroup = pGr;}

AsciiString getName() const { return m_groupName;}
const AsciiString& getName() const { return m_groupName;}
Bool isActive() const { return m_isGroupActive;}
Bool isSubroutine() const { return m_isGroupSubroutine;}
Bool hasWarnings() const { return m_hasWarnings;}
Expand Down Expand Up @@ -669,7 +669,7 @@ class Script : public MemoryPoolObject, public Snapshot
Real getCurTime() {return m_curTime;}
Int getDelayEvalSeconds() {return m_delayEvaluationSeconds;}

AsciiString getName() const { return m_scriptName;}
const AsciiString& getName() const { return m_scriptName;}
AsciiString getComment() const {return m_comment;}
AsciiString getActionComment() const {return m_actionComment;}
AsciiString getConditionComment() const {return m_conditionComment;}
Expand Down Expand Up @@ -699,7 +699,7 @@ class Script : public MemoryPoolObject, public Snapshot
OrCondition *findPreviousOrCondition( OrCondition *curOr );

// Support routines for ScriptEngine -
AsciiString getConditionTeamName() {return m_conditionTeamName;}
const AsciiString& getConditionTeamName() const {return m_conditionTeamName;}
void setConditionTeamName(AsciiString teamName) {m_conditionTeamName = teamName;}
};

Expand Down
2 changes: 1 addition & 1 deletion GeneralsMD/Code/GameEngine/Include/GameLogic/SidesList.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -330,7 +330,7 @@ class BuildListInfo : public MemoryPoolObject, public Snapshot
const Coord2D *getRallyOffset() const {return &m_rallyPointOffset;}
Real getAngle() const {return m_angle;}
Bool isInitiallyBuilt() {return m_isInitiallyBuilt;}
AsciiString getScript() {return m_script;}
const AsciiString& getScript() const {return m_script;}
Int getHealth() {return m_health;}
Bool getWhiner() {return m_whiner;}
Bool getUnsellable() {return m_unsellable;}
Expand Down
Loading