Skip to content

unify(legacy-profiler): Make both games inherit legacy profiler #3075

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Jaredl-Dev wants to merge 1 commit into from
Closed

unify(legacy-profiler): Make both games inherit legacy profiler #3075

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Core/GameEngine/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1179,6 +1179,7 @@ target_include_directories(corei_gameengine_private INTERFACE

target_link_libraries(corei_gameengine_private INTERFACE
corei_always
core_profile_legacy
)

target_compile_definitions(corei_gameengine_private INTERFACE
Expand Down
1 change: 1 addition & 0 deletions Core/Libraries/Source/profile/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ target_precompile_headers(core_profile_legacy PRIVATE
)

target_link_libraries(core_profile_legacy PRIVATE
core_debug

@xezon xezon Aug 8, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is right.

Should mirror GeneralsMD first. core_debug and core_profile_legacy is linked in 3 game targets.

@Jaredl-Dev Jaredl-Dev Aug 8, 2026 •
edited
Loading

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps I should revise this PR to implement the suggestion from #3070 (comment), and then move the changes to Core in a third commit within #3070?

@xezon xezon Aug 8, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It does not need to be a separate commit. Whereever you merge the profile code to Generals, just merge the lib linking as well.

core_wwcommon
corei_always
)
Loading