Skip to content

fix(targa): Fix TGA2 footer signature truncation by using strncpy #2527

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
xezon merged 4 commits into from
Apr 3, 2026
Merged

fix(targa): Fix TGA2 footer signature truncation by using strncpy #2527

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ca84fc0
bugfix(targa): Fix TGA2 footer signature truncation by using memcpy
bobtista Apr 2, 2026
48949fa
fix(targa): Address review comments - use strncpy, add static assert,…
bobtista Apr 3, 2026
6354979
fix(targa): Remove superfluous comments
bobtista Apr 3, 2026
ab8ad08
fix(targa): Use strlcpy with explicit size for VC6 compatibility
bobtista Apr 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions Core/Libraries/Source/WWVegas/WWLib/TARGA.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -713,7 +713,7 @@
if (!error) {

mExtension.ExtSize = 495;
strcpy(mExtension.SoftID, "Denzil's Targa Code");
strlcpy_t(mExtension.SoftID, "Denzil's Targa Code"); // TheSuperHackers @fix bobtista 03/04/2026 Replace strcpy with strlcpy_t

Check failure on line 716 in Core/Libraries/Source/WWVegas/WWLib/TARGA.cpp

View workflow job for this annotation

GitHub Actions / Build Generals / vc6+t+e 

 'unsigned int __cdecl strlcpy_t(T *,const T *,unsigned int)' : expects 3 arguments - 2 provided

Check failure on line 716 in Core/Libraries/Source/WWVegas/WWLib/TARGA.cpp

View workflow job for this annotation

GitHub Actions / Build Generals / vc6-debug+t+e 

 'unsigned int __cdecl strlcpy_t(T *,const T *,unsigned int)' : expects 3 arguments - 2 provided

Check failure on line 716 in Core/Libraries/Source/WWVegas/WWLib/TARGA.cpp

View workflow job for this annotation

GitHub Actions / Build Generals / vc6-profile+t+e 

 'unsigned int __cdecl strlcpy_t(T *,const T *,unsigned int)' : expects 3 arguments - 2 provided

Check failure on line 716 in Core/Libraries/Source/WWVegas/WWLib/TARGA.cpp

View workflow job for this annotation

GitHub Actions / Build GeneralsMD / vc6-profile+t+e 

 'unsigned int __cdecl strlcpy_t(T *,const T *,unsigned int)' : expects 3 arguments - 2 provided

Check failure on line 716 in Core/Libraries/Source/WWVegas/WWLib/TARGA.cpp

View workflow job for this annotation

GitHub Actions / Build GeneralsMD / vc6-debug+t+e 

 'unsigned int __cdecl strlcpy_t(T *,const T *,unsigned int)' : expects 3 arguments - 2 provided

Check failure on line 716 in Core/Libraries/Source/WWVegas/WWLib/TARGA.cpp

View workflow job for this annotation

GitHub Actions / Build GeneralsMD / vc6+t+e 

 'unsigned int __cdecl strlcpy_t(T *,const T *,unsigned int)' : expects 3 arguments - 2 provided

Check failure on line 716 in Core/Libraries/Source/WWVegas/WWLib/TARGA.cpp

View workflow job for this annotation

GitHub Actions / Build GeneralsMD / vc6-releaselog+t+e 

 'unsigned int __cdecl strlcpy_t(T *,const T *,unsigned int)' : expects 3 arguments - 2 provided
Comment thread
bobtista marked this conversation as resolved.
Outdated
Comment thread
bobtista marked this conversation as resolved.
Outdated
mExtension.SoftVer.Number = (1 * 100);
mExtension.SoftVer.Letter = 0;

Expand All @@ -735,7 +735,8 @@
if (!error)
{
footer.Developer = 0;
strlcpy(footer.Signature, TGA2_SIGNATURE, sizeof(footer.Signature));
static_assert(sizeof(TGA2_SIGNATURE) - 1 == sizeof(footer.Signature), "TGA2 signature length mismatch"); // TheSuperHackers @bugfix bobtista 02/04/2026 Verify TGA2 signature sizes match
Comment thread
bobtista marked this conversation as resolved.
Outdated
strncpy(footer.Signature, TGA2_SIGNATURE, sizeof(footer.Signature));
footer.RsvdChar = '.';
footer.BZST = 0;

Expand Down
Loading