fix: Resolve macro redefinition warnings

[Skyaero42]

• Related to Fix Compiler Warnings - Generals + Tools - Level 1 warnings #499
• Related to Fix Compiler Warnings - Zero Hour + Tools - Level 1 warnings #503

NUM_ALPHA_TILES in Generals\Wheightmapedit.h was unused and is removed
_WIN32_WINNT was unused and is removed
WIN32_LEAN_AND_MEAN was redefined in registry.cpp. Included win.h instead, which already handles this macro correctly.

[greptile-apps]

Greptile Summary

This PR correctly fixes three macro redefinition warnings with no behavioral impact. WIN32_LEAN_AND_MEAN in registry.cpp is replaced with win.h which guards the macro correctly, _WIN32_WINNT 0x0400 is removed from thread.cpp (already defined at the build level), and the duplicate NUM_ALPHA_TILES 8 is removed from WHeightMapEdit.h (the authoritative definition of 12 lives in WorldHeightMap.h).

Confidence Score: 5/5

Safe to merge — all changes are straightforward macro cleanup with no behavioral impact

Only P2 findings remain (redundant include). All three macro removals are correct and do not affect runtime behavior.

No files require special attention

Important Files Changed

Filename	Overview
Core/Libraries/Source/WWVegas/WWDownload/registry.cpp	Replaces manual WIN32_LEAN_AND_MEAN + windows.h with win.h include; redundant include left behind
Core/Libraries/Source/WWVegas/WWLib/thread.cpp	Removes stale _WIN32_WINNT 0x0400 macro define that caused redefinition warnings
Generals/Code/Tools/WorldBuilder/include/WHeightMapEdit.h	Removes duplicate NUM_ALPHA_TILES 8 macro that conflicted with NUM_ALPHA_TILES 12 in WorldHeightMap.h

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[registry.cpp] --> B[Registry.h]
    A --> C[win.h]
    B --> D[string]
    C --> E[WIN32_LEAN_AND_MEAN guard]
    E --> F[windows.h]
    G[thread.cpp] --> H[thread.h]
    G --> I[windows.h via ifdef _WIN32]
    J[WHeightMapEdit.h] --> K[WorldHeightMap.h]
    K --> L[NUM_ALPHA_TILES = 12]

Loading

Prompt To Fix All With AI

This is a comment left during a code review.
Path: Core/Libraries/Source/WWVegas/WWDownload/registry.cpp
Line: 24

Comment:
**Redundant `<string>` include**

`Registry.h` (included on the previous line) already includes `<string>`, making this include redundant.

```suggestion
#include <win.h>
```

How can I resolve this? If you propose a fix, please make it concise.

_{Reviews (5): Last reviewed commit: "refactor: sort includes" | Re-trigger Greptile}

[bobtista]

Could we use add_compile_definitions(WIN32_LEAN_AND_MEAN) in cmake and clean up all the individual defines?

[xezon]

The Pull title needs some polishing.

[Skyaero42]

The Pull title needs some polishing.

done

[xezon]

"win.h"

Sort alphabetically.

[Skyaero42]

Was wondering already whether that would be in scope or not. Its done now