Skip to content

chore: Simplify IOCell & IOExtras#2007

Open
camielvs wants to merge 1 commit intomasterfrom
03-24-chore_simplify_iocell
Open

chore: Simplify IOCell & IOExtras#2007
camielvs wants to merge 1 commit intomasterfrom
03-24-chore_simplify_iocell

Conversation

@camielvs
Copy link
Copy Markdown
Collaborator

@camielvs camielvs commented Mar 25, 2026 •
edited
Loading

Description

Simplify IOCell to remove the collapsible and instead display all useful info and actions more succinctly.

This removes the need for IOCellHeader and IOCellDetails components, allowing us to remove a lot of code such as bespoke text copying & non-UI primitive components.

This change introduces a Text Visualization dialog for long string artifacts when returned by the API.

Additionally, IOCell has been generalized and is now used to greatly simplify IOExtras as well.

Tests for IOCell have been removed, due to the complete overhaul of the component. New ones will be added back in as part of the Artifact Visualization work.

Related Issue and Pull requests

Lays the foundation for https://github.com/Shopify/oasis-frontend/issues/172

Type of Change

  • Improvement
  • Cleanup/Refactor

Checklist

  • I have tested this does not break current pipelines / runs functionality
  • I have tested the changes on staging

Screenshots (if applicable)

before

image.png

after

image.png

before:

image.png

after:

image.png

Test Instructions

Create a successful pipeline run. Observe artifacts for a task and confirm all currently available information is still there. Confirm also no weird UI quirks - e.g. long strings or overflowing content

Additional Comments

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 25, 2026 •
edited
Loading

🎩 To tophat this PR:

You can add the following URL parameter to your browser to tophat this PR:

`?tophat_location=03-24-chore_simplify_iocell/b7ad32a`

@camielvs Graphite App
Copy link
Copy Markdown
Collaborator Author

camielvs commented Mar 25, 2026 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

This was referenced Mar 25, 2026
Open
Closed
Open
@camielvs camielvs changed the title chore: Simplify IOCell chore: Simplify IOCell & IOExtras Mar 25, 2026
@camielvs camielvs force-pushed the 03-24-chore_simplify_iocell branch 4 times, most recently from bf6dbf9 to 34fd86b Compare March 25, 2026 20:12
This was referenced Mar 25, 2026
Open
Open
@camielvs camielvs marked this pull request as ready for review March 25, 2026 21:42
@camielvs camielvs requested a review from a team as a code owner March 25, 2026 21:42
@camielvs camielvs force-pushed the 03-24-chore_simplify_iocell branch 2 times, most recently from e6fce6d to 100407f Compare March 25, 2026 22:49
@maxy-shpfy Graphite App
Copy link
Copy Markdown
Collaborator

maxy-shpfy commented Mar 26, 2026

UX comment: have you considered keeping the top row (name - type (size) - value) same as previous version? Obviously, it's not critical, but I'm not sure I like how content "jumping" around. In legacy version it was attached to right side, making it easier to scan.

@camielvs camielvs force-pushed the 03-24-chore_simplify_iocell branch from 100407f to d63abd0 Compare March 26, 2026 00:10
maxy-shpfy
maxy-shpfy approved these changes Mar 26, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@maxy-shpfy maxy-shpfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! left suggestion and a question

@camielvs Graphite App
Copy link
Copy Markdown
Collaborator Author

camielvs commented Mar 26, 2026 •
edited
Loading

I chose to move it because the top-right made the most sense for the upcoming preview button. Arguably we could split the row into three equal portions and position the type + size in the middle

@camielvs camielvs force-pushed the 03-24-chore_simplify_iocell branch from d63abd0 to 06d943a Compare March 26, 2026 00:15
@camielvs Graphite App
Copy link
Copy Markdown
Collaborator Author

camielvs commented Mar 26, 2026

I have lined it up on the right & will try make it tidy as well when the preview button is introduced in the next PR

image.png

@camielvs Graphite App
Copy link
Copy Markdown
Collaborator Author

camielvs commented Mar 26, 2026

Reworked for visualizations
image.png

@camielvs camielvs force-pushed the 03-24-chore_simplify_iocell branch from 06d943a to 8bd00b2 Compare March 26, 2026 00:43
@camielvs camielvs force-pushed the 03-24-chore_simplify_iocell branch from 8bd00b2 to b7ad32a Compare March 26, 2026 01:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@maxy-shpfy maxy-shpfy maxy-shpfy approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@camielvs @maxy-shpfy