Skip to content

feat: Artifact Visualization#1939

Open
camielvs wants to merge 1 commit into03-24-chore_simplify_iocellfrom
03-12-poc_artifact_visualization
Open

feat: Artifact Visualization#1939
camielvs wants to merge 1 commit into03-24-chore_simplify_iocellfrom
03-12-poc_artifact_visualization

Conversation

@camielvs
Copy link
Copy Markdown
Collaborator

@camielvs camielvs commented Mar 12, 2026 •
edited
Loading

Description

Adds an Artifact Visualization Dialog for artifact types:

  • text
  • image
  • csv
  • tsv
  • Apache Parquet
  • jason object
  • json array

With fallback to text/string.

Visualization Dialog can be made fullscreen (except for JSON artifacts which use the Codeviewer system) and also provide links to the URI and source. In fullscreen mode artifact types that utilize a table format will display 30 rows instead of the default 10.

The Visualizer accepts a value or signedUrl. If signedUrl is provided it will fetch the content from remote, otherwise, it will display the value passed in.

Related Issue and Pull requests

Closes #190

Closes #191

Closes #192

Closes #193

Type of Change

  • New feature

Checklist

  • I have tested this does not break current pipelines / runs functionality
  • I have tested the changes on staging

Screenshots (if applicable)

New "Preview" Button for Artifacts

image.png

New "Expand" Button for string values

image.png

CSV & TSV Visualizer

image.png

Image Visualizer

image.png

JSON Visualizer

image.png

Parquet Visualizer

image.png

Text Visualizer

image.png

Test Instructions

  • Confirm that all non-text artifacts now have a "preview" button available
  • Confirm that text artifacts have an "expand" button and are displayed inline
  • Confirm that the visualization dialog displays remote link and uri copy functionality when available
  • Confirm that the visualization dialog can be made fullscreen and minimized again to normal size. The exception to this is JSON type which uses the in-built fullscreen functionality of our codeviewer.
  • Confirm that table-formatted artifacts display 10 rows by default, and up to 30 when in fullscreen. Confirm that these visualizers offer a "see all" button when not all rows can be displayed

Additional Comments

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 12, 2026 •
edited
Loading

🎩 To tophat this PR:

You can add the following URL parameter to your browser to tophat this PR:

`?tophat_location=03-12-poc_artifact_visualization/f5cb20c`

@camielvs Graphite App
Copy link
Copy Markdown
Collaborator Author

camielvs commented Mar 12, 2026 •
edited
Loading

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@camielvs camielvs force-pushed the 03-12-poc_artifact_visualization branch 9 times, most recently from db7bc57 to fbe8e88 Compare March 21, 2026 00:14
@camielvs camielvs force-pushed the 03-12-poc_artifact_visualization branch 3 times, most recently from 57cfc44 to 667094c Compare March 21, 2026 01:03
@camielvs camielvs mentioned this pull request Mar 23, 2026
Closed
4 tasks
@camielvs camielvs force-pushed the 03-12-poc_artifact_visualization branch 6 times, most recently from 37d6e88 to a04bc25 Compare March 24, 2026 15:22
@camielvs camielvs mentioned this pull request Mar 24, 2026
Open
3 tasks
@camielvs camielvs changed the title poc: Artifact Visualization feat: Artifact Visualization Mar 24, 2026
@camielvs camielvs force-pushed the 03-12-poc_artifact_visualization branch from a04bc25 to 18210ee Compare March 24, 2026 23:39
@camielvs camielvs changed the base branch from master to graphite-base/1939 March 25, 2026 00:21
@camielvs camielvs force-pushed the 03-12-poc_artifact_visualization branch from 18210ee to 2fdb032 Compare March 25, 2026 00:21
@camielvs camielvs changed the base branch from graphite-base/1939 to 03-24-chore_simplify_iocell March 25, 2026 00:21
@camielvs camielvs mentioned this pull request Mar 25, 2026
Open
4 tasks
@camielvs camielvs force-pushed the 03-12-poc_artifact_visualization branch from 2fdb032 to faf59cb Compare March 25, 2026 00:40
@camielvs camielvs force-pushed the 03-24-chore_simplify_iocell branch from f90e839 to 3b45fa4 Compare March 25, 2026 00:40
@camielvs camielvs force-pushed the 03-24-chore_simplify_iocell branch from e6fce6d to 100407f Compare March 25, 2026 22:49
@camielvs camielvs force-pushed the 03-12-poc_artifact_visualization branch 3 times, most recently from 6775098 to 2125f8f Compare March 25, 2026 23:06
@camielvs camielvs force-pushed the 03-24-chore_simplify_iocell branch from 100407f to d63abd0 Compare March 26, 2026 00:10
@camielvs camielvs force-pushed the 03-12-poc_artifact_visualization branch 2 times, most recently from 0785f62 to b2503e0 Compare March 26, 2026 00:15
@camielvs camielvs force-pushed the 03-24-chore_simplify_iocell branch from d63abd0 to 06d943a Compare March 26, 2026 00:15
@camielvs camielvs force-pushed the 03-12-poc_artifact_visualization branch from b2503e0 to e79c15a Compare March 26, 2026 00:43
@camielvs camielvs force-pushed the 03-24-chore_simplify_iocell branch from 06d943a to 8bd00b2 Compare March 26, 2026 00:43
@camielvs camielvs force-pushed the 03-12-poc_artifact_visualization branch 2 times, most recently from c042149 to 157494b Compare March 26, 2026 01:20
@camielvs camielvs force-pushed the 03-24-chore_simplify_iocell branch from 8bd00b2 to b7ad32a Compare March 26, 2026 01:29
@camielvs camielvs force-pushed the 03-12-poc_artifact_visualization branch 3 times, most recently from 442be21 to c6b5d1f Compare March 26, 2026 02:07
@camielvs camielvs requested a review from maxy-shpfy March 26, 2026 02:07
maxy-shpfy
maxy-shpfy approved these changes Mar 26, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@maxy-shpfy maxy-shpfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, cant test yet -waiting for backend fix

@camielvs camielvs force-pushed the 03-12-poc_artifact_visualization branch from c6b5d1f to f5cb20c Compare March 26, 2026 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@maxy-shpfy maxy-shpfy maxy-shpfy approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@camielvs @maxy-shpfy