Skip to content

fix(query-devtools): include solid deps for types #10456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Gujiassh wants to merge 1 commit into
base: main
Choose a base branch
from
+126 −61
Open

fix(query-devtools): include solid deps for types #10456

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/query-devtools/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,10 @@
"src",
"!src/__tests__"
],
"dependencies": {
"@solid-primitives/storage": "^1.3.11",
"solid-js": "^1.9.7"
},
Comment on lines +65 to +68
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai bot Apr 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
set -euo pipefail

file="packages/query-devtools/package.json"

echo "Duplicates between dependencies and devDependencies in $file:"
jq -r '
  .dependencies as $deps
  | .devDependencies as $dev
  | ($deps | keys[]) as $name
  | select($dev[$name] != null)
  | "\($name)\tdeps=\($deps[$name])\tdevDeps=\($dev[$name])"
' "$file"

echo
echo "Expected result after cleanup: no lines listed above."

Repository: TanStack/query

Length of output: 296

🏁 Script executed:

#!/bin/bash
set -euo pipefail

echo "=== Searching for runtime imports of `@solid-primitives/storage` and solid-js ==="
echo

echo "Imports of `@solid-primitives/storage`:"
rg "@solid-primitives/storage" packages/query-devtools/src/ --type ts --type tsx || echo "(no matches)"

echo
echo "Imports of solid-js:"
rg "solid-js" packages/query-devtools/src/ --type ts --type tsx || echo "(no matches)"

echo
echo "=== Checking package.json context (around lines 65-80) ==="
head -85 packages/query-devtools/package.json | tail -30

Repository: TanStack/query

Length of output: 1125

🏁 Script executed:

#!/bin/bash
set -euo pipefail

echo "=== Broader search for imports ==="
echo

echo "Files importing `@solid-primitives/storage` anywhere in src:"
rg "solid-primitives/storage" packages/query-devtools/src/ -l

echo
echo "Files importing solid-js anywhere in src:"
rg "from.*['\"]solid-js" packages/query-devtools/src/ -l

echo
echo "=== Also check if these appear in any index/export files ==="
rg "solid-primitives/storage|solid-js" packages/query-devtools/src/ -B1 -A1

echo
echo "=== Check the complete devDependencies section ==="
jq '.devDependencies | keys[] | select(. | startswith("solid") or startswith("@solid"))' packages/query-devtools/package.json

Repository: TanStack/query

Length of output: 5556

Remove duplicate package declarations from devDependencies.

The packages @solid-primitives/storage and solid-js are imported and used at runtime throughout the codebase (in DevtoolsComponent.tsx, DevtoolsPanelComponent.tsx, PiPContext.tsx, and other files). While correctly adding them to dependencies ensures consumers can resolve them, keeping them also in devDependencies creates redundancy and version-drift risk. Remove them from devDependencies (Lines 73 and 79).

♻️ Proposed cleanup 
   "devDependencies": {
     "@kobalte/core": "^0.13.4",
     "@solid-primitives/keyed": "^1.2.2",
     "@solid-primitives/resize-observer": "^2.0.26",
-    "@solid-primitives/storage": "^1.3.11",
     "@tanstack/match-sorter-utils": "^8.19.4",
     "@tanstack/query-core": "workspace:*",
     "clsx": "^2.1.1",
     "goober": "^2.1.16",
     "npm-run-all2": "^5.0.0",
-    "solid-js": "^1.9.7",
     "solid-transition-group": "^0.2.3",
     "superjson": "^2.2.2",
     "tsup-preset-solid": "^2.2.0",
     "vite-plugin-solid": "^2.11.6"
   }
🤖 Prompt for AI Agents 
Verify each finding against the current code and only fix it if needed.

In `@packages/query-devtools/package.json` around lines 65 - 68, Remove the
duplicate runtime packages from devDependencies: delete the entries for
"@solid-primitives/storage" and "solid-js" from the package.json devDependencies
block so they only appear under "dependencies"; this ensures runtime imports
(used by DevtoolsComponent.tsx, DevtoolsPanelComponent.tsx, PiPContext.tsx,
etc.) are resolved by consumers and avoids version-drift between dev and prod
declarations.

"devDependencies": {
"@kobalte/core": "^0.13.4",
"@solid-primitives/keyed": "^1.2.2",
Expand Down
Loading
Loading