fix(query-devtools): include solid deps for types

[Gujiassh]

Summary\n- add solid-js and @solid-primitives/storage as runtime dependencies of query-devtools so its published d.ts files can always resolve those modules\n- update pnpm lockfile to install the new dependencies\n\n## Testing\n- \None of the selected packages has a "test:types:tscurrent" script (fails: upstream workspace lacks the peer dependencies/types used in the core tests; see pnpm output starting at "Cannot find module '@cspell/eslint-plugin'")

Summary by CodeRabbit

• Chores
  • Updated runtime dependencies for the query-devtools package to include required libraries for enhanced functionality.

[coderabbitai]

📝 Walkthrough

Walkthrough

The packages/query-devtools/package.json manifest adds two new runtime dependencies: @solid-primitives/storage and solid-js, promoting them from devDependencies to the dependencies field for runtime use.

Changes

Cohort / File(s)	Summary
Dependency Declarations packages/query-devtools/package.json	Added @solid-primitives/storage (^1.3.11) and solid-js (^1.9.7) as runtime dependencies instead of dev-only dependencies.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

Poem

🐰 Two packages hop into the fold,
Solid roots and storage bold,
From dev to runtime they now roam,
Query devtools calls them home! 🏠✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	The PR description includes a summary of changes and testing notes but is missing the required sections from the template: the detailed 'Changes' section, the 'Checklist' section with required confirmations, and the 'Release Impact' section with changeset information.	Complete the PR description by adding the missing template sections: expand the 'Changes' section with detailed motivation, check off the 'Checklist' items, and indicate whether a changeset was generated under 'Release Impact'.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title 'fix(query-devtools): include solid deps for types' accurately reflects the main change: adding solid-js and @solid-primitives/storage as runtime dependencies to the query-devtools package.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

⚔️ Resolve merge conflicts

• Resolve merge conflict in branch fix/query-devtools-solid-deps

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@packages/query-devtools/package.json`:
- Around line 65-68: Remove the duplicate runtime packages from devDependencies:
delete the entries for "@solid-primitives/storage" and "solid-js" from the
package.json devDependencies block so they only appear under "dependencies";
this ensures runtime imports (used by DevtoolsComponent.tsx,
DevtoolsPanelComponent.tsx, PiPContext.tsx, etc.) are resolved by consumers and
avoids version-drift between dev and prod declarations.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 776d019b-e52e-4899-803d-3927245ff6a7

📥 Commits

Reviewing files that changed from the base of the PR and between 24de260 and 1137d4f.

⛔ Files ignored due to path filters (1)

• pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml

📒 Files selected for processing (1)

• packages/query-devtools/package.json

[coderabbitai]

⚠️ Potential issue | 🟡 Minor

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
set -euo pipefail

file="packages/query-devtools/package.json"

echo "Duplicates between dependencies and devDependencies in $file:"
jq -r '
  .dependencies as $deps
  | .devDependencies as $dev
  | ($deps | keys[]) as $name
  | select($dev[$name] != null)
  | "\($name)\tdeps=\($deps[$name])\tdevDeps=\($dev[$name])"
' "$file"

echo
echo "Expected result after cleanup: no lines listed above."

Repository: TanStack/query

Length of output: 296

---

🏁 Script executed:

#!/bin/bash
set -euo pipefail

echo "=== Searching for runtime imports of `@solid-primitives/storage` and solid-js ==="
echo

echo "Imports of `@solid-primitives/storage`:"
rg "@solid-primitives/storage" packages/query-devtools/src/ --type ts --type tsx || echo "(no matches)"

echo
echo "Imports of solid-js:"
rg "solid-js" packages/query-devtools/src/ --type ts --type tsx || echo "(no matches)"

echo
echo "=== Checking package.json context (around lines 65-80) ==="
head -85 packages/query-devtools/package.json | tail -30

Repository: TanStack/query

Length of output: 1125

---

🏁 Script executed:

#!/bin/bash
set -euo pipefail

echo "=== Broader search for imports ==="
echo

echo "Files importing `@solid-primitives/storage` anywhere in src:"
rg "solid-primitives/storage" packages/query-devtools/src/ -l

echo
echo "Files importing solid-js anywhere in src:"
rg "from.*['\"]solid-js" packages/query-devtools/src/ -l

echo
echo "=== Also check if these appear in any index/export files ==="
rg "solid-primitives/storage|solid-js" packages/query-devtools/src/ -B1 -A1

echo
echo "=== Check the complete devDependencies section ==="
jq '.devDependencies | keys[] | select(. | startswith("solid") or startswith("@solid"))' packages/query-devtools/package.json

Repository: TanStack/query

Length of output: 5556

---

Remove duplicate package declarations from devDependencies.

The packages @solid-primitives/storage and solid-js are imported and used at runtime throughout the codebase (in DevtoolsComponent.tsx, DevtoolsPanelComponent.tsx, PiPContext.tsx, and other files). While correctly adding them to dependencies ensures consumers can resolve them, keeping them also in devDependencies creates redundancy and version-drift risk. Remove them from devDependencies (Lines 73 and 79).

♻️ Proposed cleanup

   "devDependencies": {
     "@kobalte/core": "^0.13.4",
     "@solid-primitives/keyed": "^1.2.2",
     "@solid-primitives/resize-observer": "^2.0.26",
-    "@solid-primitives/storage": "^1.3.11",
     "@tanstack/match-sorter-utils": "^8.19.4",
     "@tanstack/query-core": "workspace:*",
     "clsx": "^2.1.1",
     "goober": "^2.1.16",
     "npm-run-all2": "^5.0.0",
-    "solid-js": "^1.9.7",
     "solid-transition-group": "^0.2.3",
     "superjson": "^2.2.2",
     "tsup-preset-solid": "^2.2.0",
     "vite-plugin-solid": "^2.11.6"
   }

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@packages/query-devtools/package.json` around lines 65 - 68, Remove the
duplicate runtime packages from devDependencies: delete the entries for
"@solid-primitives/storage" and "solid-js" from the package.json devDependencies
block so they only appear under "dependencies"; this ensures runtime imports
(used by DevtoolsComponent.tsx, DevtoolsPanelComponent.tsx, PiPContext.tsx,
etc.) are resolved by consumers and avoids version-drift between dev and prod
declarations.