test: fix FakePluginAuthError LocalizedError conformance on the CI toolchain#1851
Merged
Merged
Conversation
…st target builds on Xcode 26.4.1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
main's macOS App Tests job has been failing to compile since #1846. The test helper does not build on CI's toolchain (Xcode 26.4.1):PluginDriverErrorrefinesLocalizedErrorand supplies a defaulterrorDescriptionin an extension insideTableProPluginKit, which is built with Library Evolution (BUILD_LIBRARY_FOR_DISTRIBUTION = YES). On the Swift compiler in Xcode 26.4.1, that inherited-requirement default is not picked up as the witness for a type conforming in a different module (the test target), soFakePluginAuthErroris treated as not conforming toLocalizedError. The same code builds on Xcode 27, which is why it was not caught locally.Fix
Give
FakePluginAuthErroran expliciterrorDescription, so itsLocalizedErrorconformance no longer depends on the cross-module default being witnessed. Test-only change, noTableProPluginKitABI impact.Verification
The test target compiles again on Xcode 26.4.1.
TableProTestsis not in the SwiftLintincludedscope, so the file's existing lint state is unchanged. No CHANGELOG entry: internal test build fix, not user-facing.