test: import Foundation to fix FakePluginAuthError LocalizedError conformance on Xcode 26.4.1#1852
Merged
Merged
Conversation
…ilds on Xcode 26.4.1
…r on Xcode 26.4.1
datlechin
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #1851, which did not fix the failure.
main's macOS App Tests still fail to compile with the same error on Xcode 26.4.1:Adding an explicit
errorDescription(in #1851) did not help, so the missing witness was not the cause. The real difference: every shipping plugin error type conforms toPluginDriverErrorvia a separateextension, with the baseErrorconformance stated on the type (enum DuckDBPluginError: Error+extension DuckDBPluginError: PluginDriverError). None conform inline. The test helper was the only inlinestruct X: PluginDriverError, and on the Xcode 26.4.1 compiler that inline conformance to a resilient cross-module protocol refiningLocalizedErrorfails to synthesize the inheritedLocalizedErrorconformance.Fix
Match the pattern used by all 13 real conformers: declare
Erroron the type and addPluginDriverErrorin an extension. Test-only, noTableProPluginKitABI impact.Verification
Cannot compile-verify locally (Xcode 27 does not reproduce the 26.4.1 behavior). Relying on the macOS Tests check on this PR, which runs on the same 26.4.1 toolchain, plus the fact that this is the exact pattern shipping plugins already build with.