Add empty metadata to template_metrics on load if doesn't exist#4473
Open
chrishalcrow wants to merge 1 commit intoSpikeInterface:mainfrom
Open
Add empty metadata to template_metrics on load if doesn't exist#4473chrishalcrow wants to merge 1 commit intoSpikeInterface:mainfrom
template_metrics on load if doesn't exist#4473chrishalcrow wants to merge 1 commit intoSpikeInterface:mainfrom
Conversation
Member
|
Nice!!! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4471, using option 1.
In this PR, if you load an analyzer from version <0.104, the expected metadata for
template_metricswill be added. It's empty but has the right structure, so won't error when you do merges/splits etc.I like this solution because it ensures that all analyzers loaded with 0.104 will have the same structure.
Only issue is when you have an analyzer from <0.104 with template metrics and no templates. I think this is an edge case.
We really need to add a backwards compatibility focused test suite sometime soon...