Skip to content

Disposing Timer and CancellationTokenSource #219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
fabiodefilipposoftware wants to merge 4 commits into from
+5 −4
Closed

Disposing Timer and CancellationTokenSource #219

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
de5930e
Update BaseContext.cs
fabiodefilipposoftware May 16, 2026
8eb1523
Free memory disposing Time and CancellationTokenSource
fabiodefilipposoftware May 16, 2026
79d80ac
Update BaseContext.cs
fabiodefilipposoftware May 16, 2026
4623969
delete "lower" var and added StringComparison.OrdinalIgnoreCase
fabiodefilipposoftware May 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/BaseContext.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,6 +157,8 @@ private void Dispose(bool disposing)
if (disposing)
{
// TODO: dispose managed state (managed objects)
Timer?.Dispose();
CancellationTokenSource?.Dispose();
}

// TODO: free unmanaged resources (unmanaged objects) and override finalizer
Expand Down
7 changes: 3 additions & 4 deletions src/Producers/LdapProducer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,10 +147,9 @@ public override async Task Produce()

if (searchResult.TryGetDistinguishedName(out var distinguishedName))
{
var lower = distinguishedName.ToLower();
if (lower.Contains("cn=domainupdates,cn=system"))
if (distinguishedName.Contains("cn=domainupdates,cn=system", StringComparison.OrdinalIgnoreCase))
continue;
if (lower.Contains("cn=policies,cn=system") && (lower.StartsWith("cn=user") || lower.StartsWith("cn=machine")))
if (distinguishedName.Contains("cn=policies,cn=system", StringComparison.OrdinalIgnoreCase) && (distinguishedName.StartsWith("cn=user", StringComparison.OrdinalIgnoreCase) || distinguishedName.StartsWith("cn=machine", StringComparison.OrdinalIgnoreCase)))
continue;

await Channel.Writer.WriteAsync(searchResult, cancellationToken);
Expand Down Expand Up @@ -242,4 +241,4 @@ public override async Task ProduceConfigNC()
}
}
}
}
}
Loading