Disposing Timer and CancellationTokenSource

[fabiodefilipposoftware]

Description

Motivation and Context

Disposing items inside Dispose

• Timer?.Dispose();
• CancellationTokenSource?.Dispose();

This PR addresses: [GitHub issue or Jira ticket number]

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

• Chore (a change that does not modify the application functionality)
• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

• I have met the contributing prerequisites
  • Assigned myself to this PR
  • Added the appropriate labels
  • Associated an issue: Issues and Pull Requests README BloodHound#672
  • Read the Contributing guide: https://github.com/SpecterOps/BloodHound/wiki/Contributing
• I have ensured that related documentation is up-to-date
  • Open API docs
  • Code comments
• I have followed proper test practices
  • Added/updated tests to cover my changes
  • All new and existing tests passed

Summary by CodeRabbit

• Bug Fixes
  • Improved resource cleanup during shutdown to ensure timers and cancellation tokens are properly released.
  • Fixed LDAP result filtering to more reliably exclude specific system entries regardless of case, reducing incorrect inclusions.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 68792d63-c13f-4735-b9c5-c5c3eba8948e

📥 Commits

Reviewing files that changed from the base of the PR and between 79d80ac and 4623969.

📒 Files selected for processing (1)

• src/Producers/LdapProducer.cs

---

Walkthrough

BaseContext.Dispose(bool disposing) now disposes Timer and CancellationTokenSource; LdapProducer.Produce() uses case-insensitive DN filtering and consolidates policies/domainupdates skip logic.

Changes

Managed resource disposal and LDAP filtering

Layer / File(s)	Summary
Managed resource disposal in BaseContext src/BaseContext.cs	The managed-disposal branch of Dispose(bool disposing) adds null-conditional disposal calls for Timer and CancellationTokenSource.
LDAP distinguished-name filtering changes src/Producers/LdapProducer.cs	LDAP result skipping now uses string.Contains(..., StringComparison.OrdinalIgnoreCase) and a combined check for the cn=policies,cn=system subtree; trailing blank line removed.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 A tick, a token, then a hop,
I gently close what used to stop,
DNs match without a fuss or fight,
Everything tucked in, snug and right. 🥕✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	Description is incomplete: missing testing details, type of change checkbox, and all contributing checklist items are unchecked despite being required.	Complete all checklist items, select the appropriate change type (likely Bug fix), provide testing details, and mark completed contributing prerequisites.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title directly matches the primary change: disposing Timer and CancellationTokenSource in BaseContext.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

Tip

💬 Introducing Slack Agent: The best way for teams to turn conversations into code.

Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.

• Generate code and open pull requests
• Plan features and break down work
• Investigate incidents and troubleshoot customer tickets together
• Automate recurring tasks and respond to alerts with triggers
• Summarize progress and report instantly

Built for teams:

• Shared memory across your entire org—no repeating context
• Per-thread sandboxes to safely plan and execute work
• Governance built-in—scoped access, auditability, and budget controls

One agent for your entire SDLC. Right inside Slack.

👉 Get started

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[github-actions]

Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.

---

I have read the CLA Document and I hereby sign the CLA

---

_{You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.}