Skip to content

Add quality-scan skill and quality-loop command #492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jdalton wants to merge 3 commits into
base: main
Choose a base branch
from
+897 −424
Open

Add quality-scan skill and quality-loop command #492

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cfb4eb5
Add quality-scan skill and quality-loop command
jdalton Mar 10, 2026
7dd438c
Merge branch 'main' into add-quality-tooling
jdalton Mar 10, 2026
48bdef7
fix(quality-scan): remove socket-btm cross-project references
jdalton Mar 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 28 additions & 0 deletions .claude/commands/quality-loop.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,3 +16,31 @@ Run the quality-scan skill and fix all issues found. Repeat until zero issues re
- Do not skip architectural fixes
- Run tests after fixes to verify nothing broke
- Track iteration count and report progress

## Outstanding Architectural Issue (Requires Design Review)

### Checkpoint Cache Invalidation (High Severity)

**Issue**: Source package changes don't invalidate checkpoints properly.

**Root Cause**: Cache keys are computed AFTER `prepareExternalSources()` syncs source packages to additions/. Since cache keys hash files in additions/ (which are now synced), they match the checkpoint even though source packages changed.

**Scenario**:
1. Developer modifies `packages/binject/src/socketsecurity/binject/file.c`
2. Runs `pnpm --filter node-smol-builder clean && pnpm build`
3. `prepareExternalSources()` syncs binject → additions/source-patched/src/socketsecurity/binject/
4. Cache key computed from additions/ files matches old checkpoint
5. Build restores stale checkpoint, skips recompilation
6. **Result**: Binary contains old binject code

**Impact**: Silent build incorrectness when modifying source packages

**Proposed Solutions** (require architectural review):
- Option 1: Include source package mtimes in cache key metadata
- Option 2: Make `prepareExternalSources()` idempotent, always re-sync

**Files Affected**:
- packages/node-smol-builder/scripts/common/shared/build.mjs (collectBuildSourceFiles)
- packages/node-smol-builder/scripts/common/shared/checkpoints.mjs (cache key generation)

**Status**: Documented for architectural review and future implementation
Loading