Skip to content

Add quality-scan skill and quality-loop command#492

Open
jdalton wants to merge 3 commits intomainfrom
add-quality-tooling
Open

Add quality-scan skill and quality-loop command#492
jdalton wants to merge 3 commits intomainfrom
add-quality-tooling

Conversation

@jdalton
Copy link
Contributor

@jdalton jdalton commented Mar 10, 2026

Summary

Adds comprehensive quality scanning capabilities to improve code quality and catch issues early.

What this adds:

  • Quality-scan skill: Multi-dimensional code analysis with 7 specialized scan types
  • Quality-loop command: Iterative improvement workflow (/quality-loop)

Scan Types

  1. Documentation scan: Evaluate junior dev friendliness, examples, troubleshooting guides
  2. Critical bugs scan: Security issues, data corruption, crashes, undefined behavior
  3. Logic errors scan: Race conditions, edge cases, incorrect state management
  4. Caching bugs scan: Validation bypasses, stale data, corruption risks
  5. Workflow issues scan: Subprocess errors, cleanup failures, error handling gaps
  6. CI optimization scan: Performance improvements, caching strategies, matrix optimization
  7. Security scan: Input validation, path traversal, injection vulnerabilities

Usage

Run full scan + fix cycle:

/quality-loop

Or use Task tool for targeted analysis:

Task({
  subagent_type: 'quality-scan',
  prompt: 'Analyze codebase for critical bugs and logic errors'
})

Track Record

Successfully used in socket-btm to identify and fix 20+ issues including:

  • Critical path traversal vulnerabilities in checkpoint restoration
  • Hash collision bugs in cache key computation
  • Missing validation in artifact restoration
  • Documentation gaps for junior developers
  • Stale checkpoint detection logic
  • Size limit bypass vulnerabilities

This tooling provides proactive quality improvement and catches issues before they reach production.

Adds comprehensive quality scanning capabilities to improve code quality:

**What this adds:**
- Quality-scan skill: Multi-dimensional code analysis with 7 specialized scan types
- Quality-loop command: Iterative improvement workflow (/quality-loop)

**Scan types:**
1. Documentation scan: Evaluate junior dev friendliness, examples, troubleshooting
2. Critical bugs scan: Security issues, data corruption, crashes
3. Logic errors scan: Race conditions, edge cases, incorrect state management
4. Caching bugs scan: Validation bypasses, stale data, corruption risks
5. Workflow issues scan: Subprocess errors, cleanup failures, error handling
6. CI optimization scan: Performance, caching, matrix strategies
7. Security scan: Input validation, path traversal, injection vulnerabilities

**Usage:**
- Run `/quality-loop` for full scan + fix cycle
- Or use Task tool: subagent_type='quality-scan' for targeted analysis

Successfully used in socket-btm to identify and fix 20+ issues including:
- Critical path traversal vulnerabilities
- Hash collision bugs in cache keys
- Missing validation in checkpoint restoration
- Documentation gaps for junior developers
@jdalton jdalton force-pushed the add-quality-tooling branch from f7a65e1 to cfb4eb5 Compare March 10, 2026 01:28
Copy link
Contributor

@bmeck bmeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems good but a bit odd ref to btm

- Replace socket-btm monorepo examples with generic single-package examples
- Update test file paths from packages/*/test to test/
- Replace binpress/binflate/binject references with SDK-specific examples
- Update documentation examples to match socket-sdk-js structure
- Remove checkpoint/build system examples specific to socket-btm
- Add SDK-appropriate API error handling examples
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants