Skip to content

ci: Add concurrency groups to all workflows #599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
PierreQuinton wants to merge 3 commits into
base: main
Choose a base branch
from
+20 −0
Open

ci: Add concurrency groups to all workflows #599

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b39a4e7
ci: add concurrency groups to all workflows
PierreQuinton Mar 2, 2026
bc4b90e
ci: disable cancel-in-progress for release and claude workflows
PierreQuinton Mar 2, 2026
136508c
Merge branch 'main' into ci/add-concurrency-groups
ValerianRey Mar 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .github/workflows/build-deploy-docs.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,10 @@ on:
tags:
- 'v[0-9]*.[0-9]*.[0-9]*'

concurrency:
group: ${{ github.workflow }}-${{ github.ref }}
cancel-in-progress: false

Comment on lines +9 to +12
Copy link
Contributor

@ValerianRey ValerianRey Mar 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

  • If the github.ref is a version tag, we should never have this action running twice on the same github.ref, so this will have no effect.
  • If the github.ref is main, and we have multiple pushes to main in a short amount of time, we want to build sequentially, and cancel some of the jobs if there are too many. We want the last push to lead to a documentation building, which should be the case with this.

env:
UV_NO_SYNC: 1

Expand Down
4 changes: 4 additions & 0 deletions .github/workflows/checks.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,10 @@ on:
schedule:
- cron: '41 16 * * *' # Every day at 16:41 UTC (to avoid high load at exact hour values).

concurrency:
group: ${{ github.workflow }}-${{ github.ref }}
cancel-in-progress: true

Comment on lines +9 to +12
Copy link
Contributor

@ValerianRey ValerianRey Mar 2, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We want to cancel in-progress to avoid having to wait for previous checks to finish running before running new checks.

env:
UV_NO_SYNC: 1

Expand Down
4 changes: 4 additions & 0 deletions .github/workflows/claude.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,10 @@ on:
pull_request_review:
types: [submitted]

concurrency:
group: ${{ github.workflow }}-${{ github.ref }}
cancel-in-progress: false

Comment on lines +13 to +16
Copy link
Contributor

@ValerianRey ValerianRey Mar 2, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This workflow is a bit weird because it runs every time an issue comment is even posted (to check for a tag to claude). So I think that we want those workflows to be able to run concurrently. So I would remove the concurrency group entirely.

Suggested change
concurrency:
group: ${{ github.workflow }}-${{ github.ref }}
cancel-in-progress: false

jobs:
claude:
if: |
Expand Down
4 changes: 4 additions & 0 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,10 @@ on:
release:
types: [published]

concurrency:
group: ${{ github.workflow }}-${{ github.ref }}
cancel-in-progress: false

Comment on lines +7 to +10
Copy link
Contributor

@ValerianRey ValerianRey Mar 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should never have this workflow triggered concurrently (it would require to publish two releases in less than 3 minutes). But if this ever happens, I don't think we want to skip any job, so I think we should remove the concurrency group here and let everything run.

Suggested change
concurrency:
group: ${{ github.workflow }}-${{ github.ref }}
cancel-in-progress: false

jobs:
pypi-publish:
name: Publish to PyPI
Expand Down
4 changes: 4 additions & 0 deletions .github/workflows/title-formatter.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,10 @@ on:
pull_request_target:
types: [opened, edited, reopened, labeled, unlabeled, synchronize]

concurrency:
group: ${{ github.workflow }}-${{ github.ref }}
cancel-in-progress: true

Comment on lines +7 to +10
Copy link
Contributor

@ValerianRey ValerianRey Mar 2, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We only care about the latest change to the labels taking effect on the title.

jobs:
format-title:
runs-on: ubuntu-latest
Expand Down
Loading