Skip to content

ci: Add concurrency groups to all workflows#599

Open
PierreQuinton wants to merge 2 commits intomainfrom
ci/add-concurrency-groups
Open

ci: Add concurrency groups to all workflows#599
PierreQuinton wants to merge 2 commits intomainfrom
ci/add-concurrency-groups

Conversation

@PierreQuinton
Copy link
Contributor

No description provided.

@PierreQuinton PierreQuinton added the cc: ci Conventional commit type for changes to the CI (Github workflows and actions). label Mar 2, 2026
@github-actions github-actions bot changed the title ci: add concurrency groups to all workflows ci: Add concurrency groups to all workflows Mar 2, 2026
Comment on lines +9 to +12
concurrency:
group: ${{ github.workflow }}-${{ github.ref }}
cancel-in-progress: false

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

  • If the github.ref is a version tag, we should never have this action running twice on the same github.ref, so this will have no effect.
  • If the github.ref is main, and we have multiple pushes to main in a short amount of time, we want to build sequentially, and cancel some of the jobs if there are too many. We want the last push to lead to a documentation building, which should be the case with this.

Comment on lines +9 to +12
concurrency:
group: ${{ github.workflow }}-${{ github.ref }}
cancel-in-progress: true

Copy link
Contributor

@ValerianRey ValerianRey Mar 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We want to cancel in-progress to avoid having to wait for previous checks to finish running before running new checks.

Comment on lines +13 to +16
concurrency:
group: ${{ github.workflow }}-${{ github.ref }}
cancel-in-progress: false

Copy link
Contributor

@ValerianRey ValerianRey Mar 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This workflow is a bit weird because it runs every time an issue comment is even posted (to check for a tag to claude). So I think that we want those workflows to be able to run concurrently. So I would remove the concurrency group entirely.

Suggested change
concurrency:
group: ${{ github.workflow }}-${{ github.ref }}
cancel-in-progress: false

Comment on lines +7 to +10
concurrency:
group: ${{ github.workflow }}-${{ github.ref }}
cancel-in-progress: false

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should never have this workflow triggered concurrently (it would require to publish two releases in less than 3 minutes). But if this ever happens, I don't think we want to skip any job, so I think we should remove the concurrency group here and let everything run.

Suggested change
concurrency:
group: ${{ github.workflow }}-${{ github.ref }}
cancel-in-progress: false

Comment on lines +7 to +10
concurrency:
group: ${{ github.workflow }}-${{ github.ref }}
cancel-in-progress: true

Copy link
Contributor

@ValerianRey ValerianRey Mar 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We only care about the latest change to the labels taking effect on the title.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cc: ci Conventional commit type for changes to the CI (Github workflows and actions).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants