Integrate ohm-js v18 for faster parsing#1128
Draft
pdubroy wants to merge 4 commits intoShopify:mainfrom
Draft
Conversation
- Drop Node 18 from CI test matrix (keep only Node 20) - Change root tsconfig to target es2020, module node20 - Add moduleResolution: node overrides to codemirror-language-client and lang-jsonc to preserve their existing resolution behavior - Add skipLibCheck to vscode-extension tsconfig
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Author
|
@charlespwd fyi |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Same goals as #1116, but that PR identified several issues in the Ohm wasm packages that Claude had worked around.
The issues have been fixed upstream. I've also reorganized the packages somewhat, and expect it to be fairly stable now.