Fix cleanErrorMessage regex (not is not guaranteed to come last)

pdubroy · pdubroy · commit 12724d0af216 · 2026-02-17T20:55:46.000+01:00
diff --git a/packages/theme-check-common/src/checks/liquid-html-syntax-error/index.ts b/packages/theme-check-common/src/checks/liquid-html-syntax-error/index.ts
@@ -25,7 +25,7 @@ function isParsingErrorWithLocation(
 function cleanErrorMessage(message: string, highlight: string): string {
   return message
     .replace(/Line \d+, col \d+:\s+/, 'SyntaxError: ')
-    .replace(/(?!<expected ".+",) not .*/, ` not "${highlight}"`);
+    .replace(/ not (?:\(.*?\)|.*?)(?=, | or |$)/, ` not "${highlight}"`);
 }
 
 export const LiquidHTMLSyntaxError: LiquidCheckDefinition = {

Original file line number	Diff line number	Diff line change
`@@ -25,7 +25,7 @@ function isParsingErrorWithLocation(`
`25`	`25`	`function cleanErrorMessage(message: string, highlight: string): string {`
`26`	`26`	`return message`
`27`	`27`	`.replace(/Line \d+, col \d+:\s+/, 'SyntaxError: ')`
`28`		- .replace(/(?!<expected ".+",) not .*/, ` not "${highlight}"`);
	`28`	+ .replace(/ not (?:\(.?\)\|.?)(?=, \| or \|$)/, ` not "${highlight}"`);
`29`	`29`	`}`
`30`	`30`
`31`	`31`	`export const LiquidHTMLSyntaxError: LiquidCheckDefinition = {`