Partially migrate go to definition to use Rubydex#4015
Open
vinistock wants to merge 1 commit into03-18-migrate_type_inferrerfrom
Open
Partially migrate go to definition to use Rubydex#4015vinistock wants to merge 1 commit into03-18-migrate_type_inferrerfrom
vinistock wants to merge 1 commit into03-18-migrate_type_inferrerfrom
Conversation
vinistock
added
server
vinistock
force-pushed
the
03-18-migrate_type_inferrer
branch
from
5b864a5 to
cd9f1e7
Compare
vinistock
force-pushed
the
03-03-migrate_go_to_definition_to_use_rubydex
branch
from
f2b1b2d to
a6c13bd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This PR partially migrates go to definition to use Rubydex. It ignores constants for now as we need the visibility API to complete it. Everything else is migrated.
Implementation
There's not much that's notable other than changing to use the new APIs, but I'll highlight two things:
Commonmodule. I propose that we instead patch Rubydex's classes with LSP related things so that we can do things likedefinition.to_lsp_range(see the code). It feels a lot more elegant and, as long as we includelspin the method names, it won't really conflict with anythingAutomated Tests
I migrated our tests. The only thing to call out here is that Rust's ordering does not match the original indexer's ordering (due to how
HashMapworks).This makes no functional difference, but tests expect a very specific order to assert things. Instead of paying the price to sort the result, which is unnecessary, I just sorted in the tests.