Migrate type inferrer to use Rubydex

Author: vinistock

lib/ruby_lsp/global_state.rb

@@ -63,7 +63,7 @@ def initialize
       @index = RubyIndexer::Index.new #: RubyIndexer::Index
       @graph = Rubydex::Graph.new #: Rubydex::Graph
       @supported_formatters = {} #: Hash[String, Requests::Support::Formatter]
-      @type_inferrer = TypeInferrer.new(@index) #: TypeInferrer
+      @type_inferrer = TypeInferrer.new(@graph) #: TypeInferrer
       @addon_settings = {} #: Hash[String, untyped]
       @top_level_bundle = begin
         Bundler.with_original_env { Bundler.default_gemfile }

lib/ruby_lsp/type_inferrer.rb

@@ -5,9 +5,9 @@ module RubyLsp
   # A minimalistic type checker to try to resolve types that can be inferred without requiring a type system or
   # annotations
   class TypeInferrer
-    #: (RubyIndexer::Index index) -> void
-    def initialize(index)
-      @index = index
+    #: (Rubydex::Graph) -> void
+    def initialize(graph)
+      @graph = graph
     end
 
     #: (NodeContext node_context) -> Type?
@@ -81,11 +81,10 @@ def infer_receiver_for_call_node(node, node_context)
         receiver_name = RubyIndexer::Index.constant_name(receiver)
         return unless receiver_name
 
-        resolved_receiver = @index.resolve(receiver_name, node_context.nesting)
-        name = resolved_receiver&.first&.name
-        return unless name
+        resolved_receiver = @graph.resolve_constant(receiver_name, node_context.nesting)
+        return unless resolved_receiver
 
-        *parts, last = name.split("::")
+        *parts, last = resolved_receiver.name.split("::")
         return Type.new("#{last}::<#{last}>") if parts.empty?
 
         Type.new("#{parts.join("::")}::#{last}::<#{last}>")
@@ -96,12 +95,14 @@ def infer_receiver_for_call_node(node, node_context)
           # When invoking `new`, we recursively infer the type of the receiver to get the class type its being invoked
           # on and then return the attached version of that type, since it's being instantiated.
           type = infer_receiver_for_call_node(receiver, node_context)
-
           return unless type
 
           # If the method `new` was overridden, then we cannot assume that it will return a new instance of the class
-          new_method = @index.resolve_method("new", type.name)&.first
-          return if new_method && new_method.owner&.name != "Class"
+          declaration = @graph[type.name] #: as Rubydex::Namespace?
+          return unless declaration
+
+          new_method = declaration.find_member("new()")
+          return if new_method && new_method.owner.name != "Class"
 
           type.attached
         elsif raw_receiver
@@ -121,11 +122,11 @@ def guess_type(raw_receiver, nesting)
         .map(&:capitalize)
         .join
 
-      entries = @index.resolve(guessed_name, nesting) || @index.first_unqualified_const(guessed_name)
-      name = entries&.first&.name
-      return unless name
+      declaration = @graph.resolve_constant(guessed_name, nesting)
+      declaration ||= @graph.search(guessed_name).first
+      return unless declaration
 
-      GuessedType.new(name)
+      GuessedType.new(declaration.name)
     end
 
     #: (NodeContext node_context) -> Type
@@ -148,7 +149,6 @@ def self_receiver_handling(node_context)
     #: (NodeContext node_context) -> Type?
     def infer_receiver_for_class_variables(node_context)
       nesting_parts = node_context.nesting.dup
-
       return Type.new("Object") if nesting_parts.empty?
 
       nesting_parts.reverse_each do |part|
@@ -157,9 +157,11 @@ def infer_receiver_for_class_variables(node_context)
         nesting_parts.pop
       end
 
-      receiver_name = nesting_parts.join("::")
-      resolved_receiver = @index.resolve(receiver_name, node_context.nesting)&.first
-      return unless resolved_receiver&.name
+      resolved_receiver = @graph.resolve_constant(
+        nesting_parts.last, #: as !nil
+        nesting_parts[0...-1], #: as !nil
+      )
+      return unless resolved_receiver
 
       Type.new(resolved_receiver.name)
     end

test/requests/hover_expectations_test.rb

@@ -670,6 +670,8 @@ def baz
   end
 
   def test_hover_for_methods_shows_overload_count
+    skip("[RUBYDEX] Temporarily skipped because we don't yet index RBS methods")
+
     source = <<~RUBY
       String.try_convert
     RUBY

test/type_inferrer_test.rb

@@ -6,8 +6,8 @@
 module RubyLsp
   class TypeInferrerTest < Minitest::Test
     def setup
-      @index = RubyIndexer::Index.new
-      @type_inferrer = TypeInferrer.new(@index)
+      @graph = Rubydex::Graph.new
+      @type_inferrer = TypeInferrer.new(@graph)
     end
 
     def test_infer_receiver_type_self_inside_method
@@ -499,7 +499,9 @@ class Foo
     private
 
     def index_and_locate(source, position)
-      @index.index_single(URI::Generic.from_path(path: "/fake/path/foo.rb"), source)
+      @graph.index_source(URI::Generic.from_path(path: "/fake/path/foo.rb").to_s, source, "ruby")
+      @graph.resolve
+
       document = RubyLsp::RubyDocument.new(
         source: source,
         version: 1,