Migrate type inferrer to use Rubydex#4014
Open
vinistock wants to merge 1 commit into03-05-switch_singleton_class_names_to_new_stylefrom
Open
Migrate type inferrer to use Rubydex#4014vinistock wants to merge 1 commit into03-05-switch_singleton_class_names_to_new_stylefrom
vinistock wants to merge 1 commit into03-05-switch_singleton_class_names_to_new_stylefrom
Conversation
vinistock
added
server
vinistock
force-pushed
the
03-05-switch_singleton_class_names_to_new_style
branch
from
e50b099 to
abf5c41
Compare
vinistock
force-pushed
the
03-18-migrate_type_inferrer
branch
from
5b864a5 to
cd9f1e7
Compare
alexcrocha
reviewed
Mar 18, 2026
Comment on lines
-124
to
+127
| entries = @index.resolve(guessed_name, nesting) || @index.first_unqualified_const(guessed_name) | ||
| name = entries&.first&.name | ||
| return unless name | ||
| declaration = @graph.resolve_constant(guessed_name, nesting) | ||
| declaration ||= @graph.search(guessed_name).first | ||
| return unless declaration |
Contributor
There was a problem hiding this comment.
I notice different semantics in the APIs here. I am not very familiar with this part of the code, but I am assuming the intent is to have a best effort guess at what the type is as at this point we were not able to resolve it.
The question I have is, will @index.first_unqualified_const(guessed_name) and @graph.search(guessed_name).first return the same result, or is the heuristic different?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
We need the type inferrer to operate on the Rubydex graph instead of the old index. Otherwise, we can't migrate requests properly.
Implementation
Changed the inferrer to accept a graph and made all of the changes to maintain the existing behaviour.
Automated Tests
I had to skip a hover test while our RBS indexer doesn't handle methods. I'll use
[RUBYDEX]in all skips so that we can easily find them later.