fix(test-style): avoid escaping test-unit name regex#4012
Open
Kemalau wants to merge 1 commit intoShopify:mainfrom
Open
fix(test-style): avoid escaping test-unit name regex#4012Kemalau wants to merge 1 commit intoShopify:mainfrom
Kemalau wants to merge 1 commit intoShopify:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
--nameregex when building run-in-terminal commandsWhy
Shellwords.escapeis correct for file paths and shell arguments, but it over-escapes the regex passed to Test::Unit's--nameflag. On Windows this turns the trailing$into\\$, so the generated command matches nothing and "Run Test in Terminal" reports zero tests.Verification
test/requests/resolve_test_commands_test.rbruby/bundleare not installed here; the fix is based on the existing failing expectation pattern reported in the issue and the local diff review.