Align workspace dev commands in root dev.yml by kyle-schellen · Pull Request #69 · Shopify/checkout-kit

kyle-schellen · 2026-05-12T15:00:02Z

This bottom PR establishes the root dev.yml command shape for Checkout Kit. It adds repo-wide aggregates for Android, Swift, React Native, and Web; keeps protocol available through dev protocol <command>; standardizes format/fix and lint/style; adds the dev rn alias; and makes bare API commands print usage and fail when a required subcommand is missing.

Reviewers should focus on the command surface and whether the platform-scoped commands remain usable in isolation. Verified locally with dev.yml parsing, representative dev help output, API usage commands, and stack diff checks.

How to test

ruby -ryaml -e 'YAML.load_file("dev.yml")'
dev help android
dev help swift
dev help react-native
dev help rn
dev help web
dev android api
dev swift api
dev rn api

The bare API commands should print usage and exit non-zero.

github-actions · 2026-05-12T16:38:58Z

React Native — Coverage Report

Lines	Statements	Branches	Functions
	96.76% (239/247)	91.02% (142/156)	100% (64/64)

kyle-schellen · 2026-05-12T18:25:07Z

  supported_exts = %w[.swift .h .mm .java .js .ts .tsx]

  Find.find(dir) do |path|
+    next if path.include?('/build/generated/')


This keeps the RN license check focused on source-controlled files. Generated Android build output can exist locally after builds/codegen and does not reliably include our license header, which made dev check depend on local build state

kyle-schellen · 2026-05-12T18:26:20Z

@@ -292,7 +292,7 @@ class RCTShopifyCheckoutSheetKit: RCTEventEmitter, CheckoutDelegate {
        return NSNumber(value: available)
    }

-    @objc func initiateGeolocationRequest(_ allow: Bool) {
+    @objc func initiateGeolocationRequest(_: Bool) {


Root dev check surfaced an existing SwiftFormat issue. The parameter is intentionally unused, so _ is the correct shape here.

kieran-osgood-shopify · 2026-05-13T08:36:41Z

+
+## Dev workflow
+
+Run `dev` commands from the repo root. Use `dev up` before running commands when


Not sure if you've had success with this locally but I think telling it to use shadoenv and where to get dev from helped with certain ai sandboxing

All commands require `shadowenv exec --` prefix. shadowenv exec --dir DIR -- /opt/dev/bin/dev up shadowenv exec --dir DIR -- /opt/dev/bin/dev test [ARGS]

kieran-osgood-shopify · 2026-05-13T08:37:28Z

 - [Privacy compliance](https://shopify.dev/docs/storefronts/mobile/checkout-kit/privacy-compliance) - pass GDPR, CCPA, and ATT consent through to Shopify.
 - [Accelerated checkouts](https://shopify.dev/docs/storefronts/mobile/checkout-kit/accelerated-checkouts?extension=react-native) - Shop Pay and Apple Pay buttons for one-tap purchase on product and cart pages.

+## Development


I think we can move this section into the CONTRIBUTING.md to help keep the readme slim

kyle-schellen · 2026-05-14T00:19:30Z

@kieran-osgood-shopify Thanks for the review. I did another pass now that the lower stack merged in. I cleaned up the root dev.yml so Android/Swift/RN use a more consistent command shape, kept fix/style as aliases, restored dev swift build packages for compatibility, and fixed the protocol commands to target the moved Swift implementation.:raised_hands:

kieran-osgood-shopify · 2026-05-14T08:33:24Z

  react-native-lint-module: cd platforms/react-native && pnpm module lint
  react-native-lint-sample: cd platforms/react-native && pnpm sample lint
+  react-native-license-headers: cd platforms/react-native && ./scripts/copy_license --check
+  protocol-build: swift build --target ShopifyCheckoutProtocol


I believe dev check is mainly for lint checks (supposed to finish fast) so a build might be a bit heavy for check

Juanita-Dash

LGTM!

…lean/build)

kyle-schellen self-assigned this May 12, 2026

kyle-schellen marked this pull request as draft May 12, 2026 15:43

kyle-schellen changed the base branch from main to 05-11-move_react_native_dev_commands_under_root_dev.yml May 12, 2026 15:51

kyle-schellen changed the title ~~05 12 align workspace dev commands in root dev.yml~~ Align workspace dev commands in root dev.yml May 12, 2026

kyle-schellen force-pushed the 05-12-align_workspace_dev_commands_in_root_dev.yml branch from 7077869 to c4188d2 Compare May 12, 2026 16:23

kyle-schellen added the #gsd:50662 Rebase Checkout Kit on UCP label May 12, 2026

kyle-schellen requested a review from a team May 12, 2026 16:30

kyle-schellen force-pushed the 05-12-align_workspace_dev_commands_in_root_dev.yml branch from c4188d2 to cf8541b Compare May 12, 2026 16:37

kyle-schellen force-pushed the 05-11-move_react_native_dev_commands_under_root_dev.yml branch from f9cf466 to 79b74a1 Compare May 12, 2026 16:37

kyle-schellen marked this pull request as ready for review May 12, 2026 16:53

kyle-schellen force-pushed the 05-11-move_react_native_dev_commands_under_root_dev.yml branch from 79b74a1 to fa6fa57 Compare May 12, 2026 17:41

kyle-schellen force-pushed the 05-12-align_workspace_dev_commands_in_root_dev.yml branch 2 times, most recently from cf27458 to ea11c12 Compare May 12, 2026 18:22

kyle-schellen force-pushed the 05-11-move_react_native_dev_commands_under_root_dev.yml branch from fa6fa57 to 87da5c4 Compare May 12, 2026 18:22

kyle-schellen commented May 12, 2026

View reviewed changes

kyle-schellen force-pushed the 05-12-align_workspace_dev_commands_in_root_dev.yml branch from ea11c12 to f46976e Compare May 12, 2026 19:27

kyle-schellen force-pushed the 05-11-move_react_native_dev_commands_under_root_dev.yml branch from 87da5c4 to 3604836 Compare May 12, 2026 21:37

kyle-schellen force-pushed the 05-12-align_workspace_dev_commands_in_root_dev.yml branch 3 times, most recently from 9514af8 to de4dcf6 Compare May 13, 2026 00:07

kieran-osgood-shopify reviewed May 13, 2026

View reviewed changes

Comment thread dev.yml Outdated

kieran-osgood-shopify reviewed May 13, 2026

View reviewed changes

Comment thread dev.yml Outdated

kyle-schellen mentioned this pull request May 13, 2026

Move React Native dev commands under root dev.yml #64

Merged

11 tasks

kyle-schellen force-pushed the 05-12-align_workspace_dev_commands_in_root_dev.yml branch from de4dcf6 to d4ac612 Compare May 13, 2026 14:47

kyle-schellen force-pushed the 05-11-move_react_native_dev_commands_under_root_dev.yml branch from 3604836 to 14080fe Compare May 13, 2026 14:47

kyle-schellen mentioned this pull request May 13, 2026

Move Android dev commands under root dev.yml #35

Merged

11 tasks

kyle-schellen force-pushed the 05-12-align_workspace_dev_commands_in_root_dev.yml branch 7 times, most recently from 85710fe to 8496e6e Compare May 13, 2026 21:29

kyle-schellen requested a review from kieran-osgood-shopify May 14, 2026 00:19

kieran-osgood-shopify reviewed May 14, 2026

View reviewed changes

kyle-schellen marked this pull request as draft May 15, 2026 00:37

kyle-schellen force-pushed the 05-12-align_workspace_dev_commands_in_root_dev.yml branch from 8496e6e to c4e0c6b Compare May 20, 2026 23:36

This was referenced May 20, 2026

Centralize sample storefront configuration #175

Open

Add repo setup orchestration commands #176

Open

Polish platform check tooling #177

Closed

kyle-schellen force-pushed the 05-12-align_workspace_dev_commands_in_root_dev.yml branch 3 times, most recently from 1bf5d08 to 8575e24 Compare May 21, 2026 00:36

kyle-schellen marked this pull request as ready for review May 21, 2026 01:04

kyle-schellen force-pushed the 05-12-align_workspace_dev_commands_in_root_dev.yml branch 3 times, most recently from 9580dc7 to d73ca4c Compare May 22, 2026 15:28

Juanita-Dash reviewed May 22, 2026

View reviewed changes

Comment thread dev.yml

Juanita-Dash reviewed May 22, 2026

View reviewed changes

Comment thread dev.yml

kyle-schellen force-pushed the 05-12-align_workspace_dev_commands_in_root_dev.yml branch from d73ca4c to 3028a16 Compare May 22, 2026 18:30

Juanita-Dash approved these changes May 22, 2026

View reviewed changes

kyle-schellen force-pushed the 05-12-align_workspace_dev_commands_in_root_dev.yml branch from 3028a16 to d3d925e Compare May 24, 2026 17:04

kyle-schellen added 2 commits May 26, 2026 09:51

align workspace dev commands in root dev.yml

329c760

address review feedback (shadowenv, CONTRIBUTING dev tooling, swift c…

13564e3

…lean/build)

kyle-schellen force-pushed the 05-12-align_workspace_dev_commands_in_root_dev.yml branch from d3d925e to 13564e3 Compare May 26, 2026 14:07

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Align workspace dev commands in root dev.yml#69

Align workspace dev commands in root dev.yml#69
kyle-schellen wants to merge 2 commits into
mainfrom
05-12-align_workspace_dev_commands_in_root_dev.yml

kyle-schellen commented May 12, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented May 12, 2026 •

edited

Loading

Uh oh!

kyle-schellen May 12, 2026

Uh oh!

kyle-schellen May 12, 2026

Uh oh!

kieran-osgood-shopify May 13, 2026

Uh oh!

kieran-osgood-shopify May 13, 2026

Uh oh!

Uh oh!

Uh oh!

kyle-schellen commented May 14, 2026

Uh oh!

kieran-osgood-shopify May 14, 2026

Uh oh!

Uh oh!

Uh oh!

Juanita-Dash left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants


		## Dev workflow

		Run `dev` commands from the repo root. Use `dev up` before running commands when

Conversation

kyle-schellen commented May 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

How to test

Uh oh!

github-actions Bot commented May 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

React Native — Coverage Report

Uh oh!

kyle-schellen May 12, 2026

Choose a reason for hiding this comment

Uh oh!

kyle-schellen May 12, 2026

Choose a reason for hiding this comment

Uh oh!

kieran-osgood-shopify May 13, 2026

Choose a reason for hiding this comment

Uh oh!

kieran-osgood-shopify May 13, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

kyle-schellen commented May 14, 2026

Uh oh!

kieran-osgood-shopify May 14, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Juanita-Dash left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

kyle-schellen commented May 12, 2026 •

edited

Loading

github-actions Bot commented May 12, 2026 •

edited

Loading