Centralize sample storefront configuration#175
Open
kyle-schellen wants to merge 1 commit into
Open
Conversation
This was referenced May 20, 2026
Contributor
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced May 20, 2026
React Native — Coverage Report
|
kyle-schellen
force-pushed
the
05-12-align_workspace_dev_commands_in_root_dev.yml
branch
from
c4e0c6b to
ad39f4f
Compare
kyle-schellen
force-pushed
the
ks-shared-storefront-env
branch
from
d2be551 to
e86923e
Compare
kyle-schellen
force-pushed
the
05-12-align_workspace_dev_commands_in_root_dev.yml
branch
from
ad39f4f to
1bf5d08
Compare
kyle-schellen
force-pushed
the
ks-shared-storefront-env
branch
from
e86923e to
06f9f45
Compare
kyle-schellen
force-pushed
the
05-12-align_workspace_dev_commands_in_root_dev.yml
branch
from
1bf5d08 to
8575e24
Compare
kyle-schellen
force-pushed
the
ks-shared-storefront-env
branch
from
06f9f45 to
0e9dc0f
Compare
kyle-schellen
force-pushed
the
ks-shared-storefront-env
branch
from
0e9dc0f to
8ebd042
Compare
kyle-schellen
force-pushed
the
05-12-align_workspace_dev_commands_in_root_dev.yml
branch
2 times, most recently
from
83df290 to
9580dc7
Compare
kyle-schellen
force-pushed
the
ks-shared-storefront-env
branch
from
8ebd042 to
716abfe
Compare
kyle-schellen
force-pushed
the
05-12-align_workspace_dev_commands_in_root_dev.yml
branch
from
9580dc7 to
d73ca4c
Compare
kyle-schellen
force-pushed
the
ks-shared-storefront-env
branch
2 times, most recently
from
733c680 to
f8b72c3
Compare
kyle-schellen
force-pushed
the
05-12-align_workspace_dev_commands_in_root_dev.yml
branch
2 times, most recently
from
3028a16 to
d3d925e
Compare
kyle-schellen
force-pushed
the
ks-shared-storefront-env
branch
from
f8b72c3 to
5d6ef3d
Compare
kyle-schellen
force-pushed
the
05-12-align_workspace_dev_commands_in_root_dev.yml
branch
from
d3d925e to
13564e3
Compare
kyle-schellen
force-pushed
the
ks-shared-storefront-env
branch
from
5d6ef3d to
575a93a
Compare
kiftio
reviewed
May 26, 2026
| CUSTOMER_ACCOUNT_API_AUTH_BASE_URL=https://shopify.com/authentication/<shop id> | ||
| # Android derives Customer Account redirect and API URLs from the shop ID and version. | ||
| CUSTOMER_ACCOUNT_API_SHOP_ID=<shop id> | ||
| CUSTOMER_ACCOUNT_API_VERSION=unstable |
Contributor
There was a problem hiding this comment.
wonder if we should pin to the latest instead of using unstable here
kiftio
reviewed
May 26, 2026
| module.exports = { | ||
| __esModule: true, | ||
| default: { | ||
| API_VERSION: '2025-07', |
Contributor
There was a problem hiding this comment.
is this intentionally different from the version that appears below
Contributor
Author
There was a problem hiding this comment.
This is what I call a merge conflict artifact. 😭 Will update
kiftio
reviewed
May 26, 2026
| # Storefront details | ||
| STOREFRONT_DOMAIN=your-store.myshopify.com | ||
| STOREFRONT_ACCESS_TOKEN=your-public-storefront-access-token | ||
| STOREFRONT_MERCHANT_IDENTIFIER= |
Contributor
There was a problem hiding this comment.
do we make it clear anywhere what we use this for?
kyle-schellen
force-pushed
the
ks-shared-storefront-env
branch
from
575a93a to
94d978b
Compare
kiftio
approved these changes
May 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #69.
This PR centralizes sample storefront configuration behind a repo-root
.env. It adds.env.example,scripts/setup_storefront_env, and synthetic tests that generate/check the Android, Swift, and React Native sample config files from one shared source of truth.The shared defaults now use Storefront API
2026-04, matching main. The setup script keeps output sanitized, supports migration from existing platform-local config, and leaves optional Apple Pay / Customer Account API values blank unless provided.Verified with
bash -n scripts/setup_storefront_env scripts/test_setup_storefront_env,scripts/test_setup_storefront_env, and checks that generated platform config stays consistent.How to test
With a local
.envpresent: