Field/Function split: FieldFactory + two-level naming, remove AddLayout#336
Open
jacobmerson wants to merge 4 commits into
Open
Field/Function split: FieldFactory + two-level naming, remove AddLayout#336jacobmerson wants to merge 4 commits into
jacobmerson wants to merge 4 commits into
Conversation
jacobmerson
force-pushed
the
jacobmerson/field-function-split
branch
from
c74eefe to
bcb83df
Compare
jacobmerson
force-pushed
the
jacobmerson/conservative-transfer
branch
from
7dfbf1e to
5bda307
Compare
jacobmerson
force-pushed
the
jacobmerson/field-function-split
branch
2 times, most recently
from
0716c22 to
a16f1ea
Compare
The idea is as follows: a function space creates a function. A Function<T> represents an object that can be evaluated. A Function<T> is a Field<T>. A Field<T> itself does not have evaluation capabilities, but has everything needed to be sent over the network.
naming model, removing AddLayout. Our goal was to remove the need for AddLayout and forcing the user to *know* what layouts they needed to add. This was the simplest strategy of the ones we tested. It also aligns to the idea that fields are likely to have names anyways. So, having a field and layout both have names allows convenient cacheing of the layout communicator and naming of fields that follows on its construction.
With Function<T> being the object that handles evaluatable fields and Field<T> being the non-evaluatable object that can be used for sending over the network. This commit makes the function naming/usage consisent.
jacobmerson
force-pushed
the
jacobmerson/field-function-split
branch
from
a16f1ea to
fed617a
Compare
jacobmerson
force-pushed
the
jacobmerson/conservative-transfer
branch
from
2730ec6 to
c72ccad
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Splits field construction from the function-space concept and removes
AddLayout, reworking field construction and coupler registration around a two-level naming model.Highlights:
FieldFactory; rework construction around two-level naming, removingAddLayoutCreateFunction/CreateFieldsplitBase is
jacobmerson/conservative-transfer(#335)