Coupler transfer API#337
Draft
jacobmerson wants to merge 3 commits into
Draft
Conversation
jacobmerson
force-pushed
the
jacobmerson/field-function-split
branch
from
c74eefe to
bcb83df
Compare
jacobmerson
force-pushed
the
jacobmerson/coupler-transfer-api
branch
2 times, most recently
from
15b2bea to
01f44e5
Compare
jacobmerson
force-pushed
the
jacobmerson/field-function-split
branch
2 times, most recently
from
0716c22 to
a16f1ea
Compare
jacobmerson
force-pushed
the
jacobmerson/coupler-transfer-api
branch
from
01f44e5 to
e94d943
Compare
We had transfer in coupler a few years ago, but everything was compile time/type erasure so it made things very difficult to acomplish. This time around (pcms2) is taking a different approach and that seems to be leading us in a fairly positive direction in terms of usability.
test_coupler_transfer.cpp pulls in the PETSc-dependent transfer headers, so the target cannot compile when PETSc is disabled. Guard it like the other transfer tests (PCMS_ENABLE_PETSC AND PCMS_ENABLE_MESHFIELDS).
jacobmerson
force-pushed
the
jacobmerson/field-function-split
branch
from
a16f1ea to
fed617a
Compare
jacobmerson
force-pushed
the
jacobmerson/coupler-transfer-api
branch
from
e94d943 to
be23975
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brings field transfer back into the coupler API. PCMS had transfer in the coupler years ago, but it was compile-time / type-erased and hard to work with; this is the pcms2 take with a more usable design.
Highlights:
Couplertransfer API +transfer/transfer_method.hpptest_coupler_transfer.cppend-to-end coverageBase is
jacobmerson/field-function-split(#336). Retarget to develop once that's merged.