Skip to content
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
37 commits
Select commit Hold shift + click to select a range
f4545fe
tentative debug tree
mvicenzi Jan 13, 2026
64a3304
tweaks for success build
mvicenzi Jan 13, 2026
2dda045
move to other loop
mvicenzi Jan 13, 2026
0bd7e74
save debug only with photons
mvicenzi Jan 13, 2026
fc5e966
store photon start position in debug
mvicenzi Jan 13, 2026
69c8e17
remove old variables
mvicenzi Jan 13, 2026
e490f27
remove forgotten variable
mvicenzi Jan 13, 2026
f2ddbc9
augment gain db service
mvicenzi Mar 12, 2026
a7bb214
add gain service provider interface
mvicenzi Mar 12, 2026
60fc035
fix linking for db interface
mvicenzi Mar 12, 2026
384a5ef
update speareas database tag
mvicenzi Mar 16, 2026
213b9e0
add pmt channel status service
mvicenzi Mar 16, 2026
ee0f6af
tie up the service
mvicenzi Mar 16, 2026
be29f41
fix linking
mvicenzi Mar 16, 2026
a47faad
change kOn to kGood
mvicenzi Mar 16, 2026
27c3dea
use channel status service in pmtsim
mvicenzi Mar 16, 2026
4245aa2
update fcls for legacy vs overlay flow
mvicenzi Mar 16, 2026
8203c27
switch reco to local entry point
mvicenzi Mar 17, 2026
ca85cc3
fix sharing factory with ped algos
mvicenzi Mar 17, 2026
f457297
fix standard calibrator + add channel status service
mvicenzi Mar 17, 2026
617b74c
remove conflicting defaults
mvicenzi Mar 17, 2026
66fda19
remove mcophit from mc-overlays
mvicenzi Mar 17, 2026
a6a4bcf
never hold service pointers, you fool
mvicenzi Mar 18, 2026
bd7dd28
expose integral and bias from sampled waveform tool
mvicenzi Mar 18, 2026
2192b3b
plug in db gain and spread in simulation
mvicenzi Mar 18, 2026
46f9ef6
fix variable name
mvicenzi Mar 18, 2026
206283c
keep database use false for default non-overlay MC
mvicenzi Mar 18, 2026
09cb33c
add forgotten service
mvicenzi Mar 18, 2026
cb07257
improve prints
mvicenzi Mar 18, 2026
37ffe21
better printing
mvicenzi Mar 18, 2026
def9fd7
apply integral definition bias
mvicenzi Mar 18, 2026
b4298cf
update db tag
mvicenzi Mar 18, 2026
450f905
merge in debug tree
mvicenzi Mar 23, 2026
72f6fe6
update variable names
mvicenzi Mar 23, 2026
bda7024
TailNSigmaThreshold is wrong, should be TailNSigma
mvicenzi Mar 25, 2026
cec91e5
re-tune flash algo for new SPEAreas to match past performance
mvicenzi Mar 25, 2026
7f04d5b
add ophit integral to flashana tree
mvicenzi Mar 25, 2026
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion fcl/detsim/detsim_1d_icarus.fcl
Original file line number Diff line number Diff line change
Expand Up @@ -99,4 +99,6 @@ services.Geometry.GDML: "icarus_complete_20220518_overburden.gdml"
services.Geometry.ROOT: "icarus_complete_20220518_overburden.gdml"
physics.producers.crtdaq.G4ModuleLabel: "largeant"
physics.producers.opdaq.InputModule: "largeant"
physics.producers.opdaq.ApplyTimingDelays: false # keep false for non-overlay MC
physics.producers.opdaq.ApplyTimingDelays: false # keep false for non-overlay MC
physics.producers.opdaq.UseGainDatabase: false # keep false for non-overlay MC
physics.producers.opdaq.UseChannelStatusDatabase: false # keep false for non-overlay MC
4 changes: 3 additions & 1 deletion fcl/detsim/detsim_2d_icarus.fcl
Original file line number Diff line number Diff line change
Expand Up @@ -55,4 +55,6 @@ outputs: {
services.Geometry.GDML: "icarus_complete_20220518_overburden.gdml"
services.Geometry.ROOT: "icarus_complete_20220518_overburden.gdml"
physics.producers.crtdaq.G4ModuleLabel: "shifted"
physics.producers.opdaq.ApplyTimingDelays: false # keep false for non-overlay MC
physics.producers.opdaq.ApplyTimingDelays: false # keep false for non-overlay MC
physics.producers.opdaq.UseGainDatabase: false # keep false for non-overlay MC
physics.producers.opdaq.UseChannelStatusDatabase: false # keep false for non-overlay MC
4 changes: 3 additions & 1 deletion fcl/detsim/detsim_2d_icarus_refactored.fcl
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,8 @@ outputs: {

physics.producers.crtdaq.G4ModuleLabel: "shifted"
physics.producers.opdaq.InputModule: "pdfastsim"
physics.producers.opdaq.ApplyTimingDelays: false # keep false for non-overlay MC
physics.producers.opdaq.ApplyTimingDelays: false # keep false for non-overlay MC
physics.producers.opdaq.UseGainDatabase: false # keep false for non-overlay MC
physics.producers.opdaq.UseChannelStatusDatabase: false # keep false for non-overlay MC
physics.producers.shifted.InitAuxDetSimChannelLabel: "genericcrt"
physics.producers.shifted.InitSimPhotonsLabel: "pdfastsim"
4 changes: 3 additions & 1 deletion fcl/detsim/detsim_2d_icarus_refactored_Run4.fcl
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,6 @@

# Run3/4 optical tune
physics.producers.opdaq: @local::icarus_simpmt_run4
physics.producers.opdaq.ApplyTimingDelays: false # keep false for non-overlay MC
physics.producers.opdaq.ApplyTimingDelays: false # keep false for non-overlay MC
physics.producers.opdaq.UseGainDatabase: false # keep false for non-overlay MC
physics.producers.opdaq.UseChannelStatusDatabase: false # keep false for non-overlay MC
4 changes: 3 additions & 1 deletion fcl/detsim/detsim_2d_icarus_refactored_overlay.fcl
Original file line number Diff line number Diff line change
Expand Up @@ -4,5 +4,7 @@ physics.producers.daq: @local::icarus_simwire_wirecell_shifted_overlay

# turn off mc noise on pmt waveforms
physics.producers.opdaq: @local::icarus_simpmt_nonoise
physics.producers.opdaq.ApplyTimingDelays: true
physics.producers.opdaq.ApplyTimingDelays: true
physics.producers.opdaq.UseGainDatabase: true
physics.producers.opdaq.UseChannelStatusDatabase: true

4 changes: 3 additions & 1 deletion fcl/detsim/detsim_2d_icarus_refactored_overlay_Run4.fcl
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,6 @@

# Run3/4 optical tune (with no noise)
physics.producers.opdaq: @local::icarus_simpmt_run4_nonoise
physics.producers.opdaq.ApplyTimingDelays: true
physics.producers.opdaq.ApplyTimingDelays: true
physics.producers.opdaq.UseGainDatabase: true
physics.producers.opdaq.UseChannelStatusDatabase: true
4 changes: 3 additions & 1 deletion fcl/detsim/detsim_2d_icarus_refactored_yzsim.fcl
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,9 @@ outputs: {

physics.producers.crtdaq.G4ModuleLabel: "shifted"
physics.producers.opdaq.InputModule: "pdfastsim"
physics.producers.opdaq.ApplyTimingDelays: false # keep false for non-overlay MC
physics.producers.opdaq.ApplyTimingDelays: false # keep false for non-overlay MC
physics.producers.opdaq.UseGainDatabase: false # keep false for non-overlay MC
physics.producers.opdaq.UseChannelStatusDatabase: false # keep false for non-overlay MC
physics.producers.shifted.InitAuxDetSimChannelLabel: "genericcrt"
physics.producers.shifted.InitSimPhotonsLabel: "pdfastsim"
physics.producers.filtersed.InitSimEnergyDepositLabel: "shifted"
Expand Down
4 changes: 3 additions & 1 deletion fcl/detsim/detsim_2d_icarus_refactored_yzsim_Run4.fcl
Original file line number Diff line number Diff line change
Expand Up @@ -4,4 +4,6 @@ physics.producers.daq.wcls_main.params.YZScaleMapJson: "yzmap_gain_icarus_v4_run

# Run3/4 optical tune
physics.producers.opdaq: @local::icarus_simpmt_run4
physics.producers.opdaq.ApplyTimingDelays: false # keep false for non-overlay MC
physics.producers.opdaq.ApplyTimingDelays: false # keep false for non-overlay MC
physics.producers.opdaq.UseGainDatabase: false # keep false for non-overlay MC
physics.producers.opdaq.UseChannelStatusDatabase: false # keep false for non-overlay MC
4 changes: 3 additions & 1 deletion fcl/detsim/detsim_2d_icarus_refactored_yzsim_notrigger.fcl
Original file line number Diff line number Diff line change
Expand Up @@ -57,4 +57,6 @@ outputs: {
}

physics.producers.opdaq.InputModule: "pdfastsim"
physics.producers.opdaq.ApplyTimingDelays: false # keep false for non-overlay MC
physics.producers.opdaq.ApplyTimingDelays: false # keep false for non-overlay MC
physics.producers.opdaq.UseGainDatabase: false # keep false for non-overlay MC
physics.producers.opdaq.UseChannelStatusDatabase: false # keep false for non-overlay MC
Original file line number Diff line number Diff line change
Expand Up @@ -4,4 +4,6 @@ physics.producers.daq: @local::icarus_simwire_wirecell_yz_overlay

# turn off mc noise on pmt waveforms
physics.producers.opdaq: @local::icarus_simpmt_nonoise
physics.producers.opdaq.ApplyTimingDelays: true
physics.producers.opdaq.ApplyTimingDelays: true
physics.producers.opdaq.UseGainDatabase: true
physics.producers.opdaq.UseChannelStatusDatabase: true
4 changes: 3 additions & 1 deletion fcl/detsim/detsim_2d_icarus_refactored_yzsim_overlay.fcl
Original file line number Diff line number Diff line change
Expand Up @@ -4,4 +4,6 @@ physics.producers.daq: @local::icarus_simwire_wirecell_yz_overlay

# turn off mc noise on pmt waveforms
physics.producers.opdaq: @local::icarus_simpmt_nonoise
physics.producers.opdaq.ApplyTimingDelays: true
physics.producers.opdaq.ApplyTimingDelays: true
physics.producers.opdaq.UseGainDatabase: true
physics.producers.opdaq.UseChannelStatusDatabase: true
Original file line number Diff line number Diff line change
Expand Up @@ -4,4 +4,6 @@ physics.producers.daq.wcls_main.params.YZScaleMapJson: "yzmap_gain_icarus_v4_run

# Run3/4 optical tune (with no noise)
physics.producers.opdaq: @local::icarus_simpmt_run4_nonoise
physics.producers.opdaq.ApplyTimingDelays: true
physics.producers.opdaq.ApplyTimingDelays: true
physics.producers.opdaq.UseGainDatabase: true
physics.producers.opdaq.UseChannelStatusDatabase: true
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,9 @@ physics.producers: {

# build waveforms from simPhotons (already shifted)
physics.producers.opdaq.InputModule: "shifted::DetSim"
physics.producers.opdaq.ApplyTimingDelays: true
physics.producers.opdaq.ApplyTimingDelays: true
physics.producers.opdaq.UseGainDatabase: true
physics.producers.opdaq.UseChannelStatusDatabase: true

# make sure the triggersim chain used the "new" products
# instead of the "old" ones which I cannot drop on input
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,4 +11,6 @@
# switch to Run3/Run-4 tune
physics.producers.opdaq: @local::icarus_simpmt_run4_nonoise
physics.producers.opdaq.InputModule: "shifted::DetSim"
physics.producers.opdaq.ApplyTimingDelays: true
physics.producers.opdaq.ApplyTimingDelays: true
physics.producers.opdaq.UseGainDatabase: true
physics.producers.opdaq.UseChannelStatusDatabase: true
2 changes: 2 additions & 0 deletions fcl/reco/Definitions/stage0_icarus_driver_common.fcl
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
#include "stage0_icarus_defs.fcl"
#include "services_common_icarus.fcl"
#include "channelmapping_icarus.fcl"
#include "pmt_channel_status_icarus.fcl"

process_name: Stage0

Expand All @@ -13,6 +14,7 @@ services:
IICARUSChannelMap: @local::icarus_channelmappinggservice
IPMTTimingCorrectionService: @local::icarus_pmttimingservice
IPhotonCalibratorService: @local::icarus_photon_calibration
IPMTChannelStatusService: @local::icarus_pmt_channel_status
@table::icarus_wirecalibration_minimum_services
}

Expand Down
1 change: 0 additions & 1 deletion fcl/reco/Definitions/stage0_icarus_mc_defs.fcl
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,6 @@ icarus_stage0_overlay_PMT: [
ophituncorrected, # @local::icarus_ophit_data
ophit, # ovveride to @local::icarus_ophit_timing_correction
# this happens in enable_overlay.fcl
mcophit,
opflashCryoE,
opflashCryoW
]
Expand Down
4 changes: 3 additions & 1 deletion fcl/reco/Stage0/data/partial/decodePMT_icarus.fcl
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,7 @@
#include "services_common_icarus.fcl"
#include "channelmapping_icarus.fcl"
#include "timing_icarus.fcl"
#include "pmt_channel_status_icarus.fcl"

#include "rootoutput_icarus.fcl"
#include "decoderdefs_icarus.fcl"
Expand All @@ -71,7 +72,8 @@ services: {
DetectorClocksService: @local::icarus_detectorclocks
IICARUSChannelMap: @local::icarus_channelmappinggservice
IPMTTimingCorrectionService: @local::icarus_pmttimingservice

IPMTChannelStatusService: @local::icarus_pmt_channel_status

TFileService: { fileName: "Trees-%ifb_%tc-%p.root" }
}

Expand Down
7 changes: 0 additions & 7 deletions fcl/reco/Stage0/overlay/stage0_run3_wc_icarus_overlay.fcl

This file was deleted.

7 changes: 0 additions & 7 deletions fcl/reco/Stage0/overlay/stage0_run3_wcdnn_icarus_overlay.fcl

This file was deleted.

7 changes: 0 additions & 7 deletions fcl/reco/Stage0/overlay/stage0_run4_wc_icarus_overlay.fcl

This file was deleted.

7 changes: 0 additions & 7 deletions fcl/reco/Stage0/overlay/stage0_run4_wcdnn_icarus_overlay.fcl

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,6 @@
## This would make the data component consistent and the MC signal biased.
## Such a choice makes the configuration independent of the run period...

## ... excpet for the `mcophit` module (fake hit reconstruction)
## This module requires a fixed SPE tune (no db interface) so it must be manually set
## to the run-period SPE tune used in DetSim.

process_name: OpMCstage0

## only perform PMT/CRT MCstage0 on top of reprocessed MC overlay files
Expand All @@ -33,10 +29,5 @@ physics.path: [ @sequence::icarus_stage0_overlay_PMT,
@sequence::icarus_stage0_mc_crtreco # only reco, hits from overlay
]

## update mcophit producer to pick up Run-2 SPE tune
## (ophit picks up SPEArea from the database automatically)
physics.producers.mcophit.SPEArea: @local::SPERun2.Area
physics.producers.mcophit.SPEAmplitude: @local::SPERun2.Amplitude



This file was deleted.

This file was deleted.

9 changes: 6 additions & 3 deletions fcl/services/services_icarus_simulation.fcl
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,8 @@
#include "signalservices_icarus.fcl"
#include "photpropservices_icarus.fcl"
#include "timing_icarus.fcl"
#include "pmt_channel_status_icarus.fcl"
#include "pmt_calibration_icarus.fcl"

BEGIN_PROLOG

Expand Down Expand Up @@ -115,11 +117,12 @@ icarus_g4_services: {

# Define icarus_detsim_services ... (2*)
icarus_detsim_services: {

@table::icarus_detsim_dark_services
IPMTTimingCorrectionService: @local::icarus_pmttimingservice
# PmtGainService: @local::icarus_pmtgain_service

IPMTChannelStatusService: @local::icarus_pmt_channel_status
IPhotonCalibratorService: @local::icarus_photon_calibration

} # icarus_detsim_services


Expand Down
1 change: 1 addition & 0 deletions icaruscode/PMT/Algorithms/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ art_make_library(
SOURCE ${lib_srcs}
LIBRARIES
icaruscode::Decode_DecoderTools
icaruscode::PMT_Calibration
icarusalg::Utilities
larcorealg::Geometry
lardataobj::RawData
Expand Down
Loading